Bug 1014876

Summary: Show Failed Results doesn't show warns/panics
Product: [Retired] Beaker Reporter: Bill Peck <bpeck>
Component: web UIAssignee: Nick Coghlan <ncoghlan>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 0.15CC: aigao, asaha, dcallagh, jbenc, jingwang, llim, qwan, rmancy
Target Milestone: 0.15.1Keywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-23 06:56:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Bill Peck 2013-10-03 01:27:06 UTC 
Description of problem:
When viewing results from the job page clicking on "Show Failed Results" will not show Warn or Panic resuls.

Version-Release number of selected component (if applicable):
0.15

How reproducible:
everytime 

Steps to Reproduce:
1. find a job that has warns
2.
3.
Comment 2 Nick Coghlan 2013-10-03 02:12:35 UTC 
These states are correctly causing the "Show Failed Results" button to appear, but are not showing up when it is clicked. The result filter needs to be updated to match the one that controls whether or not the button is shown.
Comment 3 Nick Coghlan 2013-10-03 05:04:40 UTC 
OK, I figured out *why* this is breaking: the check to decide whether or not to display the button uses Recipe.is_failed, which correctly checks for warn, fail and panic results.

However, the GET request to tasks/do_search only accepts a single "result" and at the moment the failed results tab is only asking for Fail results, leaving out Warn and Panic.
Comment 4 Nick Coghlan 2013-10-03 05:27:08 UTC 
Solution will be to accept multiple "result" values for tasks/do_search and update the JS call appropriately.
Comment 5 Nick Coghlan 2013-10-03 05:52:25 UTC 
Initial patch on Gerrit: http://gerrit.beaker-project.org/2327
Comment 7 wangjing 2013-10-10 09:20:58 UTC 
verified on beaker-devel Version 0.15.0(2013-10-10)-->pass

steps:
1. click on "Show Failed Results" on job pages containing Warn results
2. click on "Show Failed Results" on job pages containing Panic results

actual results:
same as expected results.

expected results:
should show Warn/Panic results accordingly.
Comment 8 Raymond Mancy 2013-10-23 06:56:40 UTC 
beaker 0.15.1 has been released.