Bug 1014938

Summary:	chunks missing from progress bar because percentages sum to > 100
Product:	[Retired] Beaker	Reporter:	Karel Srot <ksrot>
Component:	web UI	Assignee:	Nick Coghlan <ncoghlan>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	0.15	CC:	aigao, asaha, dcallagh, jingwang, llim, qwan, rmancy
Target Milestone:	0.15.1	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-10-23 07:00:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Comment 2 Dan Callaghan 2013-10-03 07:21:41 UTC

Damn, I should have known that my round() patch for bug 660633 was too good to be true.

The Fail chunk of the progress bar is missing because the percentages sum to 101, not 100, so the final chunk (the red one) wraps and becomes invisible.

Comment 3 Nick Coghlan 2013-10-08 09:20:54 UTC

On Gerrit: http://gerrit.beaker-project.org/2333

The div styling should be able to handle fractional percentages, so simply switched to using three decimal places, which should mean any cumulative errors always amount to less than a pixel and browsers will do the right thing.

Also switched back to using truncation, so it should never sum to *more* than 100% (which, as it turns out, is worse than summing to less than 100%, since it causes the final chunk of the progress bar not to be displayed correctly)

Comment 8 wangjing 2013-10-11 03:23:03 UTC

verified on beaker-devel Version 0.15.0(2013-10-10)-->pass

steps:
check the progress bar on thus jobs:
https://beaker-devel.app.eng.bos.redhat.com/jobs/1649
https://beaker-devel.app.eng.bos.redhat.com/jobs/1433
https://beaker-devel.app.eng.bos.redhat.com/jobs/1578

actual results:
same as expected results.

expected results:
the progress bar displayed properly by the percentages without blank space.

Comment 10 Raymond Mancy 2013-10-23 07:00:32 UTC

beaker 0.15.1 has been released.