Bug 1015248

Summary:	-console installer does not exit when user selects to exit after port in use warning.
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Francisco Canas <fcanas>
Component:	Installer	Assignee:	Francisco Canas <fcanas>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Petr Kremensky <pkremens>
Severity:	medium	Docs Contact:	Russell Dickenson <rdickens>
Priority:	unspecified
Version:	6.2.0	CC:	thauser
Target Milestone:	ER5
Target Release:	EAP 6.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-15 16:21:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Francisco Canas 2013-10-03 17:56:00 UTC

Description of problem:
-console installer continues even after user selects to exit when given a 'port already in use' warning.

Version-Release number of selected component (if applicable):
ER3

How reproducible:
Every time.

Steps to Reproduce:
1.Start the -console installer when the default 9999 port is already in use.
2.When given the 'port already in use' warning, select 'no' to exit.

Actual results:
Installer continues on to target path selection.

Expected results:
Installer should exit since user chose not to continue.

Additional info:
This will likely need an izpack fix.

Comment 1 Petr Kremensky 2013-10-04 14:30:57 UTC

This is same with gui installer. Wouldn't it make more sense to quit installer once user select Cancel on warning dialogue (however I understand that correct workflow is to stay on current screen once user select cancel on warning).

I would also suggest changing the message as the port may not be required during installation (If user don't want to start server during installation and do some post-install actions). That's why this is just warning.

Comment 2 Francisco Canas 2013-10-07 17:56:19 UTC

I have fixed the logic in izpack's console panels so the result is more consistent with the GUI installer workflow: If the user chooses not to continue on a warning, installer stays on current panel rather than quitting altogether.

Izpack fix:
http://git.app.eng.bos.redhat.com/izpack.git/commit/?h=izpack-wip&id=68e3ac655c3bfa51a7c9387ad24fa36bf8214750

I also edited the message that appears when the port is already in use to:
"The port 9999 is already in use, but may be required to be open for this installation. Do you wish to continue?"

http://git.app.eng.bos.redhat.com/jbossas-installer.git/commit/?h=eap-6.2&id=3689967fcbe6c68767a7c393c3ccdfc86370b73d

Comment 3 Petr Kremensky 2013-10-08 09:39:00 UTC

Verified on EAP 6.2.0.ER5 installer.