| Summary: | fsck.btrfs not included but used by systemd startup service | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rudolf Kastl <che666> |
| Component: | systemd | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 20 | CC: | esandeen, johannbg, josef, kay, lnykryn, mmahut, msekleta, plautrba, systemd-maint, vpavlin, zbyszek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | systemd-208-6.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-24 23:48:33 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Rudolf Kastl
2013-10-04 10:38:27 UTC
In this age of journaling filesystems, it's probably best for utilities to just gracefully handle the absence of fsck.$FS - it's simply not needed at boot time, in general. Kay, before you argued that we shouldn't install fsck.btrfs, and use passno=0 by default. But this stopped working with recent changes in systemd, since we assume that /sysroot should be fsck'ed in the dracut unless explicitly disabled, and the same is true for other filesystems mounted later on. In addition, anaconda writes '1 1' for /root. So I think we could do either of: 1. provide dummy fsck.btrfs 2. stop logging when fsck.<filetype> is missing 3. modify anaconda to write '0 0' instead. 4. do nothing 4 seems unattractive, 3 will not fix every case. I guess that 2. is easiest... Should we silently ignore all cases where the checker is not found, or embed the knowledge that btrfs and xfs are special in this regard and don't require fsck? Or do we want to push for 1.? 1. Seems a bit like papering over the real problem, and getting stuck in the past :) 2. Sounds fine to me. we could use the existence of the file as an idication to run it. a bit like mount(8) calls out to mount.<fstype> and will not complain if that's not there We could still complain in the real root when we find 1 but no checker program? 3. Should be done sure, but it would not solve the dracut problem, will it? 4. Nah :) OK. Actually, we should complain if we find 1 in initramfs too. Fixed in http://cgit.freedesktop.org/systemd/systemd/commit/?id=94192cd: missing /sbin/fsck.btrfs is downgraded to a warning. For btrfs /etc/fstab should not have passno=1. systemd-208-6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/systemd-208-6.fc20 Package systemd-208-6.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing systemd-208-6.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-21935/systemd-208-6.fc20 then log in and leave karma (feedback). systemd-208-6.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |