Bug 1015610

Summary: Websocket is not working with golang
Product: OpenShift Online Reporter: Jijesh <jijeshmohan>
Component: TemplatesAssignee: Vincent Batts <vbatts>
Status: CLOSED WORKSFORME QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: ccoleman, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-21 16:54:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
testcase: diy application
none
testcase: ws:// echo test client
none
websocket working sample none

Description Jijesh 2013-10-04 15:25:58 UTC 
Description of problem:

tried to set up a simple webapplication which uses websockets written in go. The problem is that the websocket-connection isn't routed down to the webapplication and the connection closes immediately althought port 8000 is used. 

Version-Release number of selected component (if applicable):


How reproducible:

Create a new app using DIY cartridge and clone the following repo 
https://github.com/ioboi/websocket-openshift
 
For testing use http://www.websocket.org/echo.html with "ws://wsdemo-ioboi.rhcloud.com:8000/" as url. A request doesn't get routed down to the application.

Steps to Reproduce:
1. Create a new app using DIY cartridge 
2. Clone the following repo https://github.com/ioboi/websocket-openshift
3.  use http://www.websocket.org/echo.html with "ws://wsdemo-ioboi.rhcloud.com:8000/" as url.

Actual results:

A request doesn't get routed down to the application.


Expected results:

Should echo the request using websocket

Additional info:

Raised this in the openshift forum and got the reply to raise a defect https://www.openshift.com/forums/openshift/websockets-in-golang
Comment 1 Clayton Coleman 2013-10-10 13:42:49 UTC 
Golang is not a core supported cartridge - we haven't mapped the WS proxy port yet.  It may be a bit before I can get back around to this - in the meantime, I would accept a pull request for the cartridge manifest (https://github.com/smarterclayton/openshift-go-cart) to add WS support.
Comment 2 Vincent Batts 2014-01-02 21:26:48 UTC 
Created attachment 844745 [details]
testcase: diy application

this source will establish a simple websocket listener for port 8000, that is just an echo server.
Comment 3 Vincent Batts 2014-01-02 21:34:44 UTC 
Created attachment 844746 [details]
testcase: ws:// echo test client

using this app against the diy, you can test it locally to see it work, or against a public echo server.

But when you test against a golang running cartridge, the hello message makes it in to the app, but the response does not make it back from the app.

supervisor.log shows a playload.websocket: [object Object], and websockets.log shows that lines for the request:
 66.187.233.202 ws-hurr.dev.rhcloud.com - - [02/Jan/2014:15:57:13 -0500] "GET / HTTP/1.1" 1011 0 "-" "Websocket RFC-6455/13" (2ms) -
66.187.233.202 ws-hurr.dev.rhcloud.com - - [02/Jan/2014:15:57:13 -0500] "GET / HTTP/1.1" 1000 0 "-" "Websocket RFC-6455/13" (13ms) -



For further comparison, I will show two TCP streams. The first is running the web.go source on localhost, and the client.go against it (this fully works):
--------------------------
GET /echo HTTP/1.1
Host: localhost:7777
Upgrade: websocket
Connection: Upgrade
Sec-WebSocket-Key: cpfsyjW6fJ6mPH2E9XuPjw==
Origin: http://localhost/
Sec-WebSocket-Version: 13                                                                                                                                                                     
                                                                                                                                                                                              
HTTP/1.1 101 Switching Protocols                                                                                                                                                              
Upgrade: websocket                                                                                                                                                                            
Connection: Upgrade                                                                                                                                                                           
Sec-WebSocket-Accept: +t1Aiyh3QvOgcLVom16SVYKT/AU=                                                                                                                                            
                                                                                                                                                                                              
hello, world!
--------------------------

Now, I'll show the TCP stream, of this same web.go running on the golang cart, and the client.go run against it (this does not fully work):
--------------------------
GET / HTTP/1.1
Host: ws-hurr.dev.rhcloud.com:8000
Upgrade: websocket
Connection: Upgrade
Sec-WebSocket-Key: 63UPszRfYPWeOzGQY+jsNA==
Origin: http://localhost/
Sec-WebSocket-Version: 13

HTTP/1.1 101 Switching Protocols
Upgrade: websocket
Connection: Upgrade
Sec-WebSocket-Accept: ELSyYgO3qhh5JciMFAhyO63/kK8=

...V%..3I..z...$I......
--------------------------
Comment 4 Jijesh 2014-01-21 09:00:57 UTC 
I have created another DIY application with golang and used another websocket library called gorilla websocket (github.com/gorilla/websocket) and it is working fine. 

Application is hosted here : basic-mgrid.rhcloud.com

Websocket connection is : ws://basic-mgrid.rhcloud.com:8000/sock


Attaching the repo : basic.zip ( with openshift build scripts )
Comment 5 Jijesh 2014-01-21 09:01:58 UTC 
Created attachment 853036 [details]
websocket working sample

working sample
Comment 6 Vincent Batts 2014-01-21 16:53:50 UTC 
(In reply to Jijesh from comment #5)
> Created attachment 853036 [details]
> websocket working sample
> 
> working sample

Thanks for this sample. It's good to see that it works for a page loaded.
I also tried your source in a "golang" cartridge, just changing the IP and PORT env variables, it also works just fine.

I'm not convinced that it is completely sane though. We are expecting to give close attention to this codeline soon. I'm going to close this bug, as it appears to be largely a non-issue. Re-open if needed.