| Summary: | Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mosaab Alzoubi <moceap> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | i, package-review, panemade |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | islamic-menus-1.0.6-3.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-14 03:44:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Mosaab Alzoubi
2013-10-05 09:21:30 UTC
Spec URL: http://helallinux.com/paste/show.php?id=1227&mode=raw SRPM URL: http://downloads.sourceforge.net/projects/oji/srpms/islamic-menus-1.0.5-1.oj16.fc16.src.rpm Description: Catagorize islamic apps in a menu for the GNOME, KDE and other xdg-conforming desktops Fedora Account System Username: moceap The paste you are looking for does not exist. Also in my memory, spec contains a URL points to mailing lists, why? Ok, rewritten: Spec : http://helallinux.com/paste/show.php?id=1241&mode=raw SRPM : http://downloads.sourceforge.net/project/oji/srpms/islamic-menus-1.0.5-2.fc19.src.rpm There is an error in sourceforge web interface , you can get it through mirrors : http://ftp.jaist.ac.jp/pub/sourceforge/o/oj/oji/srpms/islamic-menus-1.0.5-2.fc19.src.rpm Now hosted on Ojuba project server : Spec : http://ojuba.org/oji/SPECS/islamic-menus-1.0.5-3.spec SRPM : http://ojuba.org/oji/SRPMS/islamic-menus-1.0.5-3.oji.fc19.src.rpm - Fix spec name. Spec : http://ojuba.org/oji/SPECS/islamic-menus.spec SRPM : http://ojuba.org/oji/SRPMS/islamic-menus-1.0.5-4.oji.fc19.src.rpm - To zero warnings by rpmlint. Spec : http://ojuba.org/oji/SPECS/islamic-menus.spec SRPM : http://ojuba.org/oji/SRPMS/islamic-menus-1.0.5-5.oji.fc19.src.rpm - Remove un-necessary lines about buildroot. - Use Fedora icon cache rules. - Update source line to github directly. Spec : http://ojuba.org/oji/SPECS/islamic-menus.spec SRPM : http://ojuba.org/oji/SRPMS/islamic-menus-1.0.5-6.oji.fc19.src.rpm Better include my patch: https://github.com/cicku/islamic-menus/commit/927aae332f56ae0dc0c80afb9e4d1e69b0def9ec.patch Only install -p is needed though. ----------- I looked into my system directories, strange for this: /etc/xdg/menus/applications-gnome-merged I couldn't see any reference of this directory. And fedora-review confirmed my guess: [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/xdg/menus/applications-gnome-merged [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/xdg/menus/applications- gnome-merged Please see these ref tell me the reason of using this directory: Bug 754845 https://lists.fedoraproject.org/pipermail/devel/2011-August/155342.html Welcome Christopher, Your commit pushed.
--------
So we have 2 lines:
%config(noreplace) %{_sysconfdir}/xdg/menus/applications-merged/islamic.menu
%config(noreplace) %{_sysconfdir}/xdg/menus/applications-gnome-merged/islamic.menu
If i remove second one, can I get the same result?
(In reply to Mosaab Alzoubi from comment #10) > If i remove second one, can I get the same result? I have to say I don't know this time. You may ask this in -devel list again(don't be afraid.) Thanks. It's fixed after first packaging :) https://bugzilla.gnome.org/show_bug.cgi?id=688972 I'll update this package due to updating upstream. Thanks. This example of wine.spec: http://pkgs.fedoraproject.org/cgit/wine.git/tree/wine.spec Using only one line: %config %{_sysconfdir}/xdg/menus/applications-merged/wine.menu ok DONE: SPEC URL: http://moceap.fedorapeople.org/islamic-menus.spec SRPM URL: http://moceap.fedorapeople.org/islamic-menus-1.0.6-1.oji.fc19.src.rpm Package is fine, but can you tell me how can I test it? Thanks. Yes, This program (OTHMAN) needs islamic-menus: http://rpmfind.net/linux/RPM/sourceforge/o/oj/oji/repo/othman-0.2.7-1.oj5.noarch.html http://rpmfind.net/linux/RPM/sourceforge/o/oj/oji/repo/python-othman-0.2.7-1.oj5.noarch.html ok DONE: SPEC URL: http://moceap.fedorapeople.org/islamic-menus.spec SRPM URL: http://moceap.fedorapeople.org/islamic-menus-1.0.6-2.oji.fc19.src.rpm make %{?_smp_mflags} install DESTDIR=%{buildroot}
-->
make install DESTDIR=%{buildroot}
Thank You: SPEC URL: http://moceap.fedorapeople.org/islamic-menus.spec SRPM URL: http://moceap.fedorapeople.org/islamic-menus-1.0.6-3.oji.fc19.src.rpm New Package SCM Request ======================= Package Name: islamic-menus Short Description: Islamic menus for desktops conforming with xdg standards Owners: moceap Branches: f20 f19 f18 el6 Git done (by process-git-requests). islamic-menus-1.0.6-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.fc20 islamic-menus-1.0.6-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.fc18 islamic-menus-1.0.6-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.el6 islamic-menus-1.0.6-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.fc19 islamic-menus-1.0.6-3.el6 has been pushed to the Fedora EPEL 6 stable repository. islamic-menus-1.0.6-3.fc18 has been pushed to the Fedora 18 stable repository. islamic-menus-1.0.6-3.fc19 has been pushed to the Fedora 19 stable repository. islamic-menus-1.0.6-3.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: islamic-menus New Branches: epel7 Owners: moceap Git done (by process-git-requests). |