Bug 1015801

Summary:	missing unbound patch?
Product:	[Fedora] Fedora	Reporter:	Laurent Jacquot <jk>
Component:	vpnc	Assignee:	Christian Krause <chkr>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	19	CC:	chkr, fschwarz, tmraz
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-08 11:35:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Laurent Jacquot 2013-10-05 16:03:35 UTC

It seems the patch was added in the src.rpm but not in the vpnc.spec file.

Am I confused?

cat vpnc.spec
....
Patch1:         vpnc-0.5.1-dpd.patch
Patch2:         vpnc-0.5.3-use-autodie.patch
Patch3:         vpnc-0.5.3-unbound-support.patch
....
...
%prep
%setup -q
%patch1 -p1 -b .dpd
%patch2 -p1 -b .autodie
...

Comment 1 Felix Schwarz 2014-11-02 21:50:51 UTC

The reason is that this patch was incorporated directly into Fedora's vpnc-script so technically it's not needed as a patch file anymore. The separate patch was removed from the Fedora git repo shortly after your ticket (	df0906121b052568da4bd8153c811b1b8f0941b9, 0.5.3-20.svn457.fc19) and is not present in git anymore.

The only thing which seems to be missing is a proper build for F19 as the real fix was only in 0.5.3-20 but according to https://apps.fedoraproject.org/packages/vpnc the latest version for F19 is still 0.5.3-19.

However if you don't the patch for bug 865092 in F19 I guess you're all set. Please close the ticket in case your question was answered :-)

(Even though I agree that it is not really the best approach to patch scripts from upstream without clearly a visible patch process.)

Comment 2 Felix Schwarz 2014-11-08 11:35:46 UTC

As mentioned in my previous comment the unbound patch is applied in F20+. F19 goes end-of-life support soon so I'm for fixing only critical bugs at this stage. Please reopen if you *really* need F19 support.