Bug 1016062

Summary: Missing input constraints for some of socket bindings input fields
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Petr Kremensky <pkremens>
Component: InstallerAssignee: Francisco Canas <fcanas>
Status: CLOSED CURRENTRELEASE QA Contact: Petr Kremensky <pkremens>
Severity: low Docs Contact: Russell Dickenson <rdickens>
Priority: unspecified    
Version: 6.2.0CC: fcanas, thauser
Target Milestone: ER5   
Target Release: EAP 6.2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-15 16:17:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Petr Kremensky 2013-10-07 12:29:04 UTC
Description of problem:
There is input length&content constraint for most of socket binging input fields (user can enter only digits, user cannot enter more the 5 digits). But this constraints are missing for some fields so user can enter "ss" as port number.

Input validation itself is ok (user cannot continue to next screen with "ss" as port number).

Version-Release number of selected component (if applicable):
EAP 6.2.0.ER4

How reproducible:
always

Steps to Reproduce:
 1. On Socket Bindings screen select to "Configure custom port bindings" and "Configure ports for standalone"
 2. Continue to Socket Bindings (ha-standalone) screen
 3. Navigate to "jgroups-mping Multicast-port" and intut "ssssssssss"

Actual results:
 "ssssssssss" string is put into "jgroups-mping Multicast-port" input field

Expected results:
 "" string is put into "jgroups-mping Multicast-port" input field as "s" is not a valid character for port number.

Found violations:
--- Socket Bindings (ha-standalone)
 - jgroups-mping Multicast-Port
 - jgroups-udp Multicast-Port
 - modcluster Multicast-Port
--- Socket Bindings (full-ha-standalone)
 - jgroups-mping Multicast-Port
 - jgroups-udp Multicast-Port
 - modcluster Multicast-Port
 - messaging-group Multicast-Port

Comment 1 Francisco Canas 2013-10-07 14:09:45 UTC
I've changed the input validation to numeric for the ports listed above.

http://git.app.eng.bos.redhat.com/jbossas-installer.git/commit/?h=eap-6.2&id=9b9b26799bb009d57918dcb79251cb5ae7c2b071

Comment 2 Petr Kremensky 2013-10-08 09:19:30 UTC
Verified on EAP 6.2.0.ER5 installer.