Bug 1016089

Corrected SRPM Link:
Spec URL: http://hobbes1069.fedorapeople.org/aprsdigi.spec
SRPM URL: http://hobbes1069.fedorapeople.org/aprsdigi-3.5.1-1.fc19.src.rpm

- /etc/ax25/aprsdigi.conf is not existant, and the service need it, not sure
if it wouldn't be better to have a commented entry there ( and this would
also take care of /etc/ax25/ ownership )

- aprsbeacon.service need ax25-tools ( for /usr/sbin/beacon ) but this package is
not in the requires.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2) (with incorrect FSF address)", "Unknown or generated". 9 files
     have unknown license. Detailed output of licensecheck in
     /home/misc/checkout/git/FedoraReview/1016089-aprsdigi/licensecheck.txt
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /etc/logrotate.d
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 71680 bytes in 13 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: aprsdigi-3.5.1-1.fc20.x86_64.rpm
          aprsdigi-3.5.1-1.fc20.src.rpm
aprsdigi.x86_64: W: name-repeated-in-summary C aprsdigi
aprsdigi.x86_64: W: spelling-error %description -l en_US digipeater -> digerati
aprsdigi.x86_64: W: spelling-error %description -l en_US Aprsmon -> Apron
aprsdigi.x86_64: W: spelling-error %description -l en_US javAPRS -> Javas
aprsdigi.x86_64: W: only-non-binary-in-usr-lib
aprsdigi.x86_64: W: manual-page-warning /usr/share/man/man8/aprsmon.8.gz 143: warning: macro `RP' not defined
aprsdigi.x86_64: W: non-conffile-in-etc /etc/logrotate.d/aprsdigi
aprsdigi.src: W: spelling-error Summary(en_US) aprsmon -> apron
aprsdigi.src: W: name-repeated-in-summary C aprsdigi
aprsdigi.src: W: spelling-error %description -l en_US digipeater -> digerati
aprsdigi.src: W: spelling-error %description -l en_US Aprsmon -> Apron
aprsdigi.src: W: spelling-error %description -l en_US javAPRS -> Javas
2 packages and 0 specfiles checked; 0 errors, 12 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint aprsdigi
aprsdigi.x86_64: W: name-repeated-in-summary C aprsdigi
aprsdigi.x86_64: W: spelling-error %description -l en_US digipeater -> digerati
aprsdigi.x86_64: W: spelling-error %description -l en_US Aprsmon -> Apron
aprsdigi.x86_64: W: spelling-error %description -l en_US javAPRS -> Javas
aprsdigi.x86_64: W: only-non-binary-in-usr-lib
aprsdigi.x86_64: W: manual-page-warning /usr/share/man/man8/aprsmon.8.gz 143: warning: macro `RP' not defined
aprsdigi.x86_64: W: non-conffile-in-etc /etc/logrotate.d/aprsdigi
1 packages and 0 specfiles checked; 0 errors, 7 warnings.
# echo 'rpmlint-done:'



Requires
--------
aprsdigi (rpmlib, GLIBC filtered):
    /bin/sh
    kernel-modules-extra
    libax25.so.0()(64bit)
    libc.so.6()(64bit)
    rtld(GNU_HASH)
    systemd



Provides
--------
aprsdigi:
    aprsdigi
    aprsdigi(x86-64)



Source checksums
----------------
http://downloads.sourceforge.net/aprsdigi/aprsdigi-3.5.1.tar.gz :
  CHECKSUM(SHA256) this package     : fff28052d0d93d136fe8d66fadf134c037156c0196933bf9c0a798276e0c3344
  CHECKSUM(SHA256) upstream package : fff28052d0d93d136fe8d66fadf134c037156c0196933bf9c0a798276e0c3344


Generated by fedora-review 0.4.0 (cf29f98) last change: 2013-02-08
Command line :./try-fedora-review -b 1016089
Buildroot used: fedora-20-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Thanks for taking up the review! I don't actually use this program but it was on the ham radio sig wish list. Hopefully I'll find some time to take care of the problems you found in the near future.

Spec URL: http://hobbes1069.fedorapeople.org/aprsdigi.spec
SRPM URL: http://hobbes1069.fedorapeople.org/aprsdigi-3.5.1-2.fc19.src.rpm

- Created dummy aprsdigi.conf file which points to documentation.
- Added ax25-tools as a requirement.
- Mark config files appropriately so they don't get overwritten on update.

Issues blocking have corrected, so approved.

New Package SCM Request
=======================
Package Name: aprsdigi
Short Description: AX.25 Automatic Position Reporting System
Owners: hobbes1069
Branches: f19 f20
InitialCC:

Git done (by process-git-requests).

aprsdigi-3.5.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/aprsdigi-3.5.1-2.fc20

aprsdigi-3.5.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/aprsdigi-3.5.1-2.fc19

aprsdigi-3.5.1-2.fc19 has been pushed to the Fedora 19 testing repository.

aprsdigi-3.5.1-2.fc20 has been pushed to the Fedora 20 stable repository.

aprsdigi-3.5.1-2.fc19 has been pushed to the Fedora 19 stable repository.