Bug 1016415

Summary: 802.1q VLAN sub interface cannot be created on veth interface
Product: Red Hat OpenStack Reporter: Midokura <dev>
Component: kernelAssignee: Thomas Graf <tgraf>
Status: CLOSED CURRENTRELEASE QA Contact: Jean-Tsung Hsiao <jhsiao>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 3.0CC: hateya, lwang, rkhan, tgraf, yeylon
Target Milestone: beta   
Target Release: 4.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: kernel-2.6.32-425.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1018158 (view as bug list) Environment:
Last Closed: 2013-12-04 17:52:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1018158    
Bug Blocks:    

Description Midokura 2013-10-08 06:54:49 UTC
Description of problem:

The title says it all.


Version-Release number of selected component (if applicable):

[root@localhost ~]# uname -a
Linux localhost.localdomain 2.6.32-358.118.1.openstack.el6.x86_64 #1 SMP Wed Aug 14 13:18:08 EDT 2013 x86_64 x86_64 x86_64 GNU/Linux

How reproducible:

100%


Steps to Reproduce:
1. ip link add type veth
2. ip link add link veth0 name veth0.2 type vlan id 2


Actual results:

[root@localhost ~]# ip link add link veth0 name veth0.2 type vlan id 2
RTNETLINK answers: Operation not supported

[root@localhost ~]# dmesg  | tail -n 1
8021q: device veth0 has buggy VLAN hw accel


Expected results:

A new netdevice veth0.2 gets created without any errors. 


Additional info:

Below is the culprit and NETIF_F_HW_VLAN_RX flag seems strange for veth interface. 

net/8021q/vlan.c:

206        if ((real_dev->features & NETIF_F_HW_VLAN_RX) && !ops->ndo_vlan_rx_register) {
207                pr_info("8021q: device %s has buggy VLAN hw accel\n", name);
208                return -EOPNOTSUPP;
209        }

Comment 2 Thomas Graf 2013-10-11 10:48:41 UTC
(In reply to Midokura from comment #0)
> Below is the culprit and NETIF_F_HW_VLAN_RX flag seems strange for veth
> interface. 
> 
> net/8021q/vlan.c:
> 
> 206        if ((real_dev->features & NETIF_F_HW_VLAN_RX) &&
> !ops->ndo_vlan_rx_register) {
> 207                pr_info("8021q: device %s has buggy VLAN hw accel\n",
> name);
> 208                return -EOPNOTSUPP;
> 209        }

I agree, the NETIF_F_HW_VLAN_RX flag has been added by mistake when NETIF_F_HW_VLAN_TX was added.

Comment 4 Thomas Graf 2013-10-28 11:08:55 UTC
See:
https://bugzilla.redhat.com/show_bug.cgi?id=1018158#c7

Comment 5 Lon Hohberger 2013-12-04 17:52:04 UTC
This is resolved by the RHEL 6.5 kernel.