Bug 1016476

Summary:

Review Request: spring-retry - Abstraction around retrying failed operations

Product:

[Fedora] Fedora

Reporter:

Michal Srb <msrb>

Component:

Package Review

Assignee:

gil cattaneo <puntogil>

Status:

CLOSED RAWHIDE

QA Contact:

Fedora Extras Quality Assurance <extras-qa>

Severity:

medium

Docs Contact:

Priority:

medium

Version:

rawhide

CC:

notting, package-review, puntogil

Target Milestone:

---

Flags:

puntogil: fedora-review+
gwync: fedora-cvs+

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2013-10-16 13:23:50 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Attachments:

Description	Flags
review notes	none

Description Michal Srb 2013-10-08 08:51:09 UTC

Spec URL: http://msrb.fedorapeople.org/review/spring-retry.spec
SRPM URL: http://msrb.fedorapeople.org/review/spring-retry-1.0.2-1.fc21.src.rpm
Description: Spring Retry provides an abstraction around retrying failed operations,
with an emphasis on declarative control of the process and policy-based
bahaviour that is easy to extend and customize. For instance, you can
configure a plain POJO operation to retry if it fails, based on the type
of exception, and with a fixed or exponential backoff.
Fedora Account System Username: msrb

Comment 1 gil cattaneo 2013-10-08 15:39:26 UTC

i would like to take this review

Comment 2 gil cattaneo 2013-10-08 15:45:25 UTC

hi
org.aspectj:aspectjrt classes are available in the (our,Debian,*Ubuntu) aspectjweaver package, if you want run same tests
regards

Comment 3 gil cattaneo 2013-10-08 15:59:35 UTC

Created attachment 809378 [details]
review notes

NON blocking issues

[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.

[!]: Package does not include license text files separate from upstream.

please, contact upstream to include a license copy

[?]: If tests are skipped during package build explain why it was needed in a
     comment
     Note: Tests seem to be skipped. Verify there is a commment giving a
     reason for this
see previous comment
approved

Comment 4 Michal Srb 2013-10-15 06:22:19 UTC

(In reply to gil cattaneo from comment #2)
> hi
> org.aspectj:aspectjrt classes are available in the (our,Debian,*Ubuntu)
> aspectjweaver package, if you want run same tests
> regards

Thanks for the info. Package aspectjweaver in Fedora only provides org.aspectj:aspectjweaver. Maybe only alias is missing. I will check if it works with spring-retry.

Comment 5 gil cattaneo 2013-10-15 10:38:09 UTC

can you add also OSGi manifest?
%pom_add_plugin org.apache.felix:maven-bundle-plugin . '
<extensions>true</extensions>
<configuration>
  <instructions>
    <Bundle-SymbolicName>org.springframework.retry</Bundle-SymbolicName>
    <Bundle-Name>${project.name}</Bundle-Name>
    <Bundle-Vendor>SpringSource</Bundle-Vendor>
    <Bundle-Version>${project.version}</Bundle-Version>
  </instructions>
</configuration>
<executions>
  <execution>
    <id>bundle-manifest</id>
    <phase>process-classes</phase>
    <goals>
      <goal>manifest</goal>
    </goals>
  </execution>
</executions>'

or <Bundle-Vendor>${project.organization.name}</Bundle-Vendor>
if project.organization.name is equal to SpringSource
regards

Comment 6 Michal Srb 2013-10-16 08:52:39 UTC

No problem, I will add OSGi metadata. I have also opened pull request for adding ASL 2.0 license text and tests are enabled now.

New Package SCM Request
=======================
Package Name: spring-retry
Short Description: Abstraction around retrying failed operations
Owners: msrb sochotni mizdebsk msimacek
Branches: f20
InitialCC: java-sig

Comment 7 Gwyn Ciesla 2013-10-16 12:17:57 UTC

Git done (by process-git-requests).

Comment 8 Michal Srb 2013-10-16 13:23:50 UTC

Thanks for the review and the repo. The package is now available in Rawhide.