Bug 1016644

Summary: Maven mutliproject upload should recognize archive type
Product: [JBoss] JBoss Fuse Service Works 6 Reporter: Kurt T Stam <kurt.stam>
Component: DT GovernanceAssignee: Eric Wittmann <eric.wittmann>
Status: MODIFIED --- QA Contact: Stefan Bunciak <sbunciak>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.1.0CC: ldimaggi, soa-p-jira
Target Milestone: ER7   
Target Release: FUTURE   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kurt T Stam 2013-10-08 13:15:46 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 JBoss JIRA Server 2013-10-10 15:42:05 UTC
Kurt Stam <kurt.stam> updated the status of jira SRAMP-248 to Resolved

Comment 2 JBoss JIRA Server 2013-10-10 15:42:12 UTC
Kurt Stam <kurt.stam> updated the status of jira SRAMP-248 to Closed

Comment 4 Stefan Bunciak 2014-01-17 10:32:30 UTC
I modified the repo url in quickstarts/overlord/sramp/s-ramp-demos-switchyard-multiapp/pom.xml
to <url>sramp://localhost:8080/s-ramp-server/?artifactGrouping=${project.groupId}</url> (omitting artifactType parameter) and all the artifacts were recognized as JavaArchive:

switchyard-quickstart-demo-multi-web-0.3.1.Final-redhat-6-sources.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-web-0.3.1.Final-redhat-6-tests.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-web-0.3.1.Final-redhat-6.war	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-order-consumer-0.3.1.Final-redhat-6-sources.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-order-consumer-0.3.1.Final-redhat-6-tests.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-order-consumer-0.3.1.Final-redhat-6.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-order-service-0.3.1.Final-redhat-6-sources.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-order-service-0.3.1.Final-redhat-6-tests.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-order-service-0.3.1.Final-redhat-6.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-artifacts-0.3.1.Final-redhat-6-sources.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-artifacts-0.3.1.Final-redhat-6-classes.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-artifacts-0.3.1.Final-redhat-6-tests.jar	JavaArchive	01/17/2014
switchyard-quickstart-demo-multi-artifacts-0.3.1.Final-redhat-6.jar	JavaArchive	01/17/2014
s-ramp-demos-switchyard-multiapp-0.3.1.Final-redhat-6-tests.jar	JavaArchive	01/17/2014

I suppose at least switchyard-quickstart-demo-multi-order-service-0.3.1.Final-redhat-6.jar should be SwitchYardApplication and switchyard-quickstart-demo-multi-web-0.3.1.Final-redhat-6.war Java Web Application.

Comment 5 kconner 2014-01-18 01:22:40 UTC
Is this being rejected by QA?

Comment 8 Kurt T Stam 2014-01-22 15:05:44 UTC
Hi Stefan,

The surest way to get the artifactType you want is to set it (in the GUI or on the pom url. If you don't it will try to find a good mapping based on files in the archive; for example to detect a Switchyard archive we look for:

aMap.put("WEB-INF/switchyard.xml", SwitchYardModel.SwitchYardApplication); 
aMap.put("WEB-INF/classes/META-INF/switchyard.xml", SwitchYardModel.SwitchYardApplication);
aMap.put("META-INF/switchyard.xml", SwitchYardModel.SwitchYardApplication);

Comment 9 Kurt T Stam 2014-01-23 01:57:49 UTC
This code runs on the client side. I will take a look what's going on here. Note that this running the demo outside of what's specified in the README. That said I expected this to work, and it's not.

Comment 10 Kurt T Stam 2014-01-23 16:35:50 UTC
Fix for the zip type recognition code running on the client side:

https://github.com/Governance/s-ramp/pull/378

Comment 11 Kurt T Stam 2014-03-31 15:47:11 UTC
Small fix to take the artifact hints order into account:
https://github.com/Governance/s-ramp/pull/388

Comment 12 Gary Brown 2014-06-18 10:09:50 UTC
Please retest against 6.1.0.