Bug 1016716

Summary:	ovirt-engine 3rd party dependencies closeup
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Alon Bar-Lev <alonbl>
Component:	ovirt-engine	Assignee:	Martin Perina <mperina>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jiri Belka <jbelka>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	acathrow, bazulay, iheim, lpeer, mperina, pstehlik, Rhev-m-bugs, yeylon, yzaslavs
Target Milestone:	---
Target Release:	3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:	is24	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-21 22:13:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1019461, 1038284

Description Alon Bar-Lev 2013-10-08 14:55:28 UTC

During the work on 3.3 manifest martin found that there are missing dependencies of 3rd party component at the 2nd level and on.

Although code is working, it is better to add these dependencies to be safe than sorry.

org.tukaani:xz:jar:1.0
c3p0:c3p0:jar:0.9.1.1
aopalliance:aopalliance:jar:1.0

During this work, please also make sure that the module dependencies as in module.xml is correct and up-to-date.

Comment 4 Jiri Belka 2013-11-20 16:03:00 UTC

is24:

# find /usr/share/ovirt-engine/modules/ -type l | xargs ls -l | awk '{ print $NF,$(NF-1),$(NF-2) }' | egrep "tukaani|c3p0|aopall"
# find /usr/share/ovirt-engine/modules/ -type f | egrep "tukaani|c3p0|aopall"
/usr/share/ovirt-engine/modules/org/aopalliance/main/aopalliance.jar
/usr/share/ovirt-engine/modules/org/aopalliance/main/module.xml
/usr/share/ovirt-engine/modules/org/tukaani/xz/main/xz.jar
/usr/share/ovirt-engine/modules/org/tukaani/xz/main/module.xml
/usr/share/ovirt-engine/modules/com/mchange/c3p0/main/c3p0.jar
/usr/share/ovirt-engine/modules/com/mchange/c3p0/main/module.xml

The are not symlinks... So?

Comment 5 Alon Bar-Lev 2013-11-20 16:08:33 UTC

find -type l produces only symlinks... are you sure thse are not?

# ls -la /usr/share/ovirt-engine/modules/org/aopalliance/main/aopalliance.jar

Comment 6 Jiri Belka 2013-11-20 16:15:41 UTC

# ls -la /usr/share/ovirt-engine/modules/org/aopalliance/main/aopalliance.jar
-rw-rw-r--. 1 root root 10388 Nov 19 17:00 /usr/share/ovirt-engine/modules/org/aopalliance/main/aopalliance.jar

Comment 7 Alon Bar-Lev 2013-11-20 16:23:28 UTC

(In reply to Jiri Belka from comment #6)
> # ls -la /usr/share/ovirt-engine/modules/org/aopalliance/main/aopalliance.jar
> -rw-rw-r--. 1 root root 10388 Nov 19 17:00
> /usr/share/ovirt-engine/modules/org/aopalliance/main/aopalliance.jar

Right.

# rpm -qlvp rhevm-backend-3.3.0-0.35.beta1.el6ev.noarch.rpm | grep aopalliance.jar
-rw-rw-r--    1 root    root                    10388 Nov 19 18:00 /usr/share/ovirt-engine/modules/org/aopalliance/main/aopalliance.jar

This patch was not included in beta1 tag which is what we have in latest_is, why has this moved to on qa?

Comment 8 Alon Bar-Lev 2013-11-20 16:24:29 UTC

It is included in is24 but this build is not available in latest_is.

Comment 9 Alon Bar-Lev 2013-11-20 16:31:22 UTC

It cannot fail qa if you check a version that is before the fixed in version.

Comment 10 Martin Perina 2013-11-27 10:18:21 UTC

Included in is25

Comment 11 Jiri Belka 2013-11-27 15:09:33 UTC

is25.

# find /usr/share/ovirt-engine/modules/ -type l | xargs ls -l | egrep "tukaani|c3p0|aopall" | sed 's#^[^/]*##;'
/usr/share/ovirt-engine/modules/com/mchange/c3p0/main/c3p0.jar -> /usr/share/java/rhevm-dependencies/3.3/c3p0.jar
/usr/share/ovirt-engine/modules/org/aopalliance/main/aopalliance.jar -> /usr/share/java/rhevm-dependencies/3.3/aopalliance.jar
/usr/share/ovirt-engine/modules/org/tukaani/xz/main/xz.jar -> /usr/share/java/rhevm-dependencies/3.3/xz.jar
# ls -l /usr/share/java/rhevm-dependencies/3.3/
total 0
lrwxrwxrwx. 1 root root 22 Nov 18 10:28 aopalliance.jar -> ../aopalliance-1.0.jar
lrwxrwxrwx. 1 root root 19 Nov 18 10:28 c3p0.jar -> ../c3p0-0.9.2.1.jar
lrwxrwxrwx. 1 root root 27 Nov 18 10:28 commons-compress.jar -> ../commons-compress-1.5.jar
lrwxrwxrwx. 1 root root 32 Nov 18 10:28 commons-configuration.jar -> ../commons-configuration-1.9.jar
lrwxrwxrwx. 1 root root 29 Nov 18 10:28 commons-httpclient.jar -> ../commons-httpclient-3.1.jar
lrwxrwxrwx. 1 root root 25 Nov 18 10:28 commons-jxpath.jar -> ../commons-jxpath-1.3.jar
lrwxrwxrwx. 1 root root 26 Nov 18 10:28 glance-client.jar -> ../glance-client-3.0.1.jar
lrwxrwxrwx. 1 root root 25 Nov 18 10:28 glance-model.jar -> ../glance-model-3.0.1.jar
lrwxrwxrwx. 1 root root 24 Nov 18 10:28 gwt-servlet.jar -> ../gwt-servlet-2.5.1.jar
lrwxrwxrwx. 1 root root 28 Nov 18 10:28 keystone-client.jar -> ../keystone-client-3.0.1.jar
lrwxrwxrwx. 1 root root 27 Nov 18 10:28 keystone-model.jar -> ../keystone-model-3.0.1.jar
lrwxrwxrwx. 1 root root 22 Nov 18 10:28 mina-core.jar -> ../mina-core-2.0.4.jar
lrwxrwxrwx. 1 root root 29 Nov 18 10:28 openstack-client.jar -> ../openstack-client-3.0.1.jar
lrwxrwxrwx. 1 root root 31 Nov 18 10:28 postgresql-jdbc.jar -> ../postgresql-9.1-903.jdbc4.jar
lrwxrwxrwx. 1 root root 27 Nov 18 10:28 quantum-client.jar -> ../quantum-client-3.0.1.jar
lrwxrwxrwx. 1 root root 26 Nov 18 10:28 quantum-model.jar -> ../quantum-model-3.0.1.jar
lrwxrwxrwx. 1 root root 19 Nov 18 10:28 quartz.jar -> ../quartz-2.1.2.jar
lrwxrwxrwx. 1 root root 31 Nov 18 10:28 resteasy-connector.jar -> ../resteasy-connector-3.0.1.jar
lrwxrwxrwx. 1 root root 31 Nov 18 10:28 spring-aop.jar -> ../spring-aop-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 31 Nov 18 10:28 spring-asm.jar -> ../spring-asm-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 33 Nov 18 10:28 spring-beans.jar -> ../spring-beans-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 35 Nov 18 10:28 spring-context.jar -> ../spring-context-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 32 Nov 18 10:28 spring-core.jar -> ../spring-core-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 38 Nov 18 10:28 spring-expression.jar -> ../spring-expression-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 38 Nov 18 10:28 spring-instrument.jar -> ../spring-instrument-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 32 Nov 18 10:28 spring-jdbc.jar -> ../spring-jdbc-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 37 Nov 18 10:28 spring-ldap-core.jar -> ../spring-ldap-core-1.3.1.RELEASE.jar
lrwxrwxrwx. 1 root root 32 Nov 18 10:28 spring-test.jar -> ../spring-test-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 30 Nov 18 10:28 spring-tx.jar -> ../spring-tx-3.1.1.RELEASE.jar
lrwxrwxrwx. 1 root root 22 Nov 18 10:28 sshd-core.jar -> ../sshd-core-0.7.0.jar
lrwxrwxrwx. 1 root root 28 Nov 18 10:28 ws-commons-util.jar -> ../ws-commons-util-1.0.2.jar
lrwxrwxrwx. 1 root root 26 Nov 18 10:28 xmlrpc-client.jar -> ../xmlrpc-client-3.1.3.jar
lrwxrwxrwx. 1 root root 26 Nov 18 10:28 xmlrpc-common.jar -> ../xmlrpc-common-3.1.3.jar
lrwxrwxrwx. 1 root root 13 Nov 18 10:28 xz.jar -> ../xz-1.3.jar

Comment 12 Itamar Heim 2014-01-21 22:13:36 UTC

Closing - RHEV 3.3 Released

Comment 13 Itamar Heim 2014-01-21 22:21:27 UTC

Closing - RHEV 3.3 Released