Bug 1016865

Summary: [deploy][origin_runtime_277] First deploy using git ref after a binary deployment will fail
Product: OpenShift Online Reporter: Fabiano Franz <ffranz>
Component: ContainersAssignee: Dan Mace <dmace>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 2.xCC: chunchen, dmace, pmorie, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-17 13:34:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Fabiano Franz 2013-10-08 20:20:05 UTC 
Description of problem: 

When using the new deployment commands, the first deployment of a git ref (say 'master') after a binary deployment will fail with:

An error occurred executing 'gear deploy' (exit code: 1)
Error message: Shell command '/bin/cp -a app-root/runtime/dependencies/. app-deployments/2013-10-08_15-52-57.930/dependencies' returned an error. rc=1
stdout:
stderr: /bin/cp: cannot stat `app-root/runtime/dependencies/.`: No such file or directory

Version-Release number of selected component (if applicable):

How reproducible: always

Steps to Reproduce:
1. deploy a binary (succeeds)
2. deploy a git ref like 'master' (will fail)
3. deploy a git ref like 'master' (will succeed)

Actual results: first deployment of a git ref after a binary deployment will fail

Expected results: deployment works

Additional info:

Full logs:

http://pastebin.test.redhat.com/168961
Comment 1 Dan Mace 2013-10-09 18:45:11 UTC 
https://github.com/openshift/origin-server/pull/3805
Comment 2 chunchen 2013-10-10 06:07:06 UTC 
It's fixed, verified on devenv_3880, please refer to the following results:

1. Create an app
rhc app create cphp00 php-5.3
2. Show the UUID of this app
rhc app show cphp00 --gears
3. Set deployment type to binary
curl -k -H "Accept: application/xml" --user "chunchen:redhat7" https://ec2-50-16-93-25.compute-1.amazonaws.com/broker/rest/application/52563c179f5d5096ea000031 -X PUT -d auto_deploy=false -d deployment_type=binary
4. Create a binary
rhc snapshot save cphp00 --deployment
5. Deploy this binary
rhc deploy ./cphp00.tar.gz -a cphp00
6. Deploy a git ref like 'master'
rhc deploy master -a cphp00
7. Deploy a git ref like 'master' again
rhc deploy master -a cphp00

Results:
at step 5:
Deployment of file '/root/test/cphp00.tar.gz' in progress for application cphp00 ... done

at step 6 & 7:
Deployment of git ref 'master' in progress for application cphp00 ... Stopping PHP cartridge
Waiting for stop to finish
Building git ref 'master', commit fc35a09
Building PHP cartridge
Preparing build for deployment
Prepared deployment artifacts in /var/lib/openshift/52563c179f5d5096ea000031/app-deployments/2013-10-10_01-47-23.672
Deployment id is 94c61b0a
Activating deployment
Starting PHP cartridge
done