Bug 1017006
| Summary: | Editor for camel routes throws exceptions to eclipse .log if any component selected | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Fuse Service Works 6 | Reporter: | Jiri Sedlacek <jsedlace> |
| Component: | Tooling | Assignee: | Brian Fitzpatrick <bfitzpat> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Len DiMaggio <ldimaggi> |
| Severity: | urgent | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.0.0 GA | CC: | apodhrad, dlesage, oskutka, rcernich, soa-p-jira |
| Target Milestone: | ER6 | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
If you import a camel route into JBoss Developer Studio and click on any component in the graphical route editor, exceptions are thrown. These are recorded in the eclipse.log file. This is due to an MultiPageEditor class listener being overridden.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-02-06 15:27:15 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jiri Sedlacek
2013-10-09 06:54:24 UTC
Paul, can you see this gets to Fuse folks? Thanks! Sure - will take a look myself. Btw note that this happens only when we open the route from switchyard editor. This doesn't appear to involve Fuse (other than selecting an object in the fuse camel route editor can also trigger the issue). See: https://github.com/jboss-switchyard/tools/blob/master/eclipse/plugins/org.switchyard.tools.ui.editor/src/org/switchyard/tools/ui/editor/impl/MultiPageEditor.java#L226-233 There's code in the selectionChanged listener to try to handle a MultiPageEditor from a GraphicalEditor but it seems to confuse graphiti. Sending over to Fitz for a look. ref: java.lang.UnsupportedOperationException: Please use DataMapping.getBusinessObject(PictogramLink link) at org.eclipse.graphiti.internal.ExternalPictogramLink.getBusinessObjects(ExternalPictogramLink.java:51) at org.eclipse.graphiti.features.impl.UpdateNoBoFeature.updateNeeded(UpdateNoBoFeature.java:57) at org.eclipse.graphiti.ui.internal.action.UpdateAction.calculateEnabled(UpdateAction.java:79) at org.eclipse.gef.ui.actions.WorkbenchPartAction.refresh(WorkbenchPartAction.java:131) at org.eclipse.gef.ui.actions.SelectionAction.handleSelectionChanged(SelectionAction.java:89) at org.eclipse.gef.ui.actions.SelectionAction.setSelection(SelectionAction.java:101) at org.eclipse.gef.ui.actions.SelectionAction.update(SelectionAction.java:124) at org.eclipse.gef.ui.parts.GraphicalEditor.updateActions(GraphicalEditor.java:458) at org.switchyard.tools.ui.editor.impl.MultiPageEditor$DesignEditor.selectionChanged(MultiPageEditor.java:231) Brian Fitzpatrick <bfitzpat> made a comment on jira SWITCHYARD-1775 This turned out to be an issue with a selection changed listener in the MultiPageEditor class. After talking about it with Rob, we discovered that the overridden listener wasn't needed any more (http://git.eclipse.org/c/gmp/org.eclipse.gmp.graphiti.git/tree/plugins/org.eclipse.graphiti.ui/src/org/eclipse/graphiti/ui/editor/DiagramEditor.java#n631). And in fact, without it, everything works fine now. So this must have been an issue in older versions of Graphiti that has been resolved. Brian Fitzpatrick <bfitzpat> made a comment on jira SWITCHYARD-1775 Removes overridden method no longer required by Graphiti that was causing the issue. Rob Cernich <rcernich> made a comment on jira SWITCHYARD-1775 pushed Verified with JBDS-IS 7.0.0.CR2 Keith Babo <kbabo> updated the status of jira SWITCHYARD-1775 to Closed |