Bug 1017089

Summary:	New Kerberos user failed to be enabled
Product:	[Retired] Zanata	Reporter:	Ding-Yi Chen <dchen>
Component:	Authentication-Kerberos	Assignee:	Carlos Munoz <camunoz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Zanata-QA Mailling List <zanata-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.1	CC:	aeng, camunoz, dchen, sflaniga, zanata-bugs
Target Milestone:	---
Target Release:	3.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	3.1.1-SNAPSHOT (20131011-1008)	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-11-27 03:24:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Ding-Yi Chen 2013-10-09 09:03:08 UTC

Description of problem:
After sign in with Kerberos the first time and clicked activated link,
zanata failed to enable that user.

Version-Release number of selected component (if applicable):
3.1-SNAPSHOT (20131008-1236)

How reproducible:
Always

Steps to Reproduce:
1. Log in with a new user
2. Click activation link in activation email.
3. Log in

Actual results:
The user was disabled.

Expected results:
The user should be enabled.

Additional info:

Comment 1 Carlos Munoz 2013-10-10 03:50:48 UTC

This was apparently being caused by changes to our entity classes (access type).

See:
https://github.com/zanata/zanata-server/pull/223

Comment 2 Sean Flanigan 2013-10-10 03:57:54 UTC

This should be fixed by https://github.com/zanata/zanata-server/commit/27711d6b4c9019a00e1f78a9447215275895919e which reverts the Lombok/field-based changes to our entities.

Apparently Hibernate's dirtiness detection isn't triggered when using field-based reflection from Seam's IdentityManager.enableUser() and grantRole() (probably because they never call *any* methods on the entities).  Moving the relevant Seam annotations for HAccount from the fields (HAccount.enabled and HAccount.roles) back to accessor methods seems to fix it.

However, due to https://hibernate.atlassian.net/browse/HHH-3718 the use of field access for the id field of entities could be causing a performance problem by preventing lazy loading.  See also http://blog.xebia.com/2009/06/13/jpa-implementation-patterns-field-access-vs-property-access/ and http://stackoverflow.com/a/3739197/14379 

I suggest we try field access again for Zanata 3.2, but with annotated methods and property access just for the Seam identity properties and for all the entity id fields.

Comment 3 Sean Flanigan 2013-10-10 07:51:17 UTC

Could you please give this a quick retest against 3.1.2-SNAPSHOT?

Comment 4 Ding-Yi Chen 2013-10-11 00:38:41 UTC

VERIFIED with Zanata version 3.1.1-SNAPSHOT (20131011-1008)

Comment 5 Sean Flanigan 2013-11-27 03:14:16 UTC

Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 6 Sean Flanigan 2013-11-27 03:16:05 UTC

Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 7 Sean Flanigan 2013-11-27 03:19:57 UTC

Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 8 Sean Flanigan 2013-11-27 03:24:00 UTC

Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 9 Sean Flanigan 2013-11-27 03:34:48 UTC

Closing VERIFIED bugs for Zanata versions <= 3.1.

Comment 10 Sean Flanigan 2013-11-27 03:36:54 UTC

Closing VERIFIED bugs for Zanata versions <= 3.1.