Bug 1017101

Summary: Unhelpful error message when logging in to a disabled account
Product: [Retired] Zanata Reporter: Ding-Yi Chen <dchen>
Component: Authentication-OpenID, Authentication-FedoraAssignee: Carlos Munoz <camunoz>
Status: CLOSED DUPLICATE QA Contact: Zanata-QA Mailling List <zanata-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.1CC: camunoz, sflaniga, zanata-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1018630 (view as bug list) Environment:
Last Closed: 2013-10-14 00:54:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Ding-Yi Chen 2013-10-09 09:17:11 UTC
Description of problem:
After sign in with open ID, the server log stated that the verification succeeded,
but user is still not login.

Version-Release number of selected component (if applicable):
Zanata version 3.1-SNAPSHOT (20131008-1236)

How reproducible:
Always for OpenId
Fedora and Google work though.

Steps to Reproduce:
1. Log In with Open Id (Such as WordPress)

Actual results:
Nothing happened

Expected results:
User is logged in

Additional info:

Server Log:
09:12:07,645 INFO  [org.openid4java.consumer.ConsumerManager] (http-/0.0.0.0:8080-5) Verifying authentication response...
09:12:07,646 INFO  [org.openid4java.consumer.ConsumerManager] (http-/0.0.0.0:8080-5) Received positive auth response.
09:12:07,646 INFO  [org.openid4java.consumer.ConsumerManager] (http-/0.0.0.0:8080-5) Consumer nonce signature verified.
09:12:07,647 INFO  [org.openid4java.consumer.ConsumerManager] (http-/0.0.0.0:8080-5) Found association: {HMAC-SHA1}{52551a02}{c5TG6A==} verifying signature locally...
09:12:07,647 INFO  [org.openid4java.consumer.ConsumerManager] (http-/0.0.0.0:8080-5) Verification succeeded for: http://dingyichen.wordpress.com/

Comment 1 Carlos Munoz 2013-10-10 03:51:09 UTC
This was apparently being caused by changes to our entity classes (access type).

See:
https://github.com/zanata/zanata-server/pull/223

Comment 2 Ding-Yi Chen 2013-10-10 06:53:21 UTC
After comparing the results tested by Carlos, we found that the real cause of the bug is Zanata does not show error message when the account is disabled.

Steps to reproduce:
1. Register your open-id to Zanata
2. Sign out
3. Admin disable  your open-id account
4. Re-Login with your open-id Zanata

Actual:
User was not loginned, yet nothing happened.

Expected:
An error message shows to user: "Your account are not yet enabled, contact admin to enable your account".

Comment 3 Ding-Yi Chen 2013-10-10 06:59:19 UTC
It happened to all the openId types, such as Fedora, Google, Yahoo, and generic openid. 
Internal authentication is working though.

Comment 4 Sean Flanigan 2013-10-10 07:48:54 UTC
We won't hold up 3.1.1 for this, but we should fix it for 3.1.2.

Comment 5 Carlos Munoz 2013-10-11 00:44:19 UTC
When a user authenticates and the account hasn't been enabled (i.e. verified), shouldn't it go to the page where Zanata re-sends the verification email?

Comment 6 Ding-Yi Chen 2013-10-11 00:46:08 UTC
(In reply to Carlos Munoz from comment #5)
> When a user authenticates and the account hasn't been enabled (i.e.
> verified), shouldn't it go to the page where Zanata re-sends the
> verification email?

That's true for internal authentication.
But for OpenIds it shows nothing.

Comment 7 Ding-Yi Chen 2013-10-14 00:54:31 UTC

*** This bug has been marked as a duplicate of bug 1018630 ***