Bug 1017494

Summary: Unhelpful scrolling behaviour when reporting error with external tracker change
Product: [Community] Bugzilla Reporter: Jason McDonald <jmcdonal>
Component: Creating/Changing BugsAssignee: Matt Tyson 🤬 <mtyson>
Status: CLOSED CURRENTRELEASE QA Contact: Simon Green <sgreen>
Severity: low Docs Contact:
Priority: low    
Version: 4.4CC: ebaak, jmcdonal, mtyson, rjoost
Target Milestone: 4.4   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.4.1013 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-04 01:13:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jason McDonald 2013-10-10 03:30:32 UTC
Description of problem:
When a user has JavaScript enabled and incorrectly enters external tracker details (e.g. by choosing a tracker and not entering a bug identifier), pressing the top Submit button results in the page scrolling so that the error message inserted below the external tracker line is positioned just below the bottom edge of the browser window and thus not visible to the user, who may be left confused about why the form was not submitted.

Version-Release number of selected component (if applicable):
4.4.0009 (and Firefox 23)

How reproducible:
Always

Steps to Reproduce:
1. Ensure that JavaScript is enabled in your browser.
2. View a bug that has no external trackers set.
3. Choose a tracker from the drop-down list but leave the ID field blank.
4. Scroll up to the top Submit button. If necessary resize you browser window so that the External Trackers table is below the bottom of the browser window.
5. Press the Submit button.

Actual results:
The page scrolls so that the External Tracker field is shown at the bottom of the window, but the error message on the next line is below the bottom edge of the browser window.

Expected results:
The page should be scrolled so that both the incorrect External Tracker setting and the error message are visible.

Additional info:
none.

Comment 1 Matt Tyson 🤬 2014-01-13 04:17:52 UTC
On firefox the browser would scroll to the offending field on a validation
error, but scroll as far as error message which was below the field.

Chrome scrolled to the error message.

I've fixed it so it will now scroll to the error message in both chrome and firefox.

Comment 3 Jason McDonald 2014-02-04 01:13:43 UTC
This change is now live. If there are any issues, do not reopen this bug.
Instead, you should create a new bug and reference this bug.