Bug 1017536

Summary:	Duplication warning messages when creating scalable app with empty git repo
Product:	OpenShift Online	Reporter:	Meng Bo <bmeng>
Component:	Image	Assignee:	Jakub Hadvig <jhadvig>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	medium
Version:	2.x	CC:	cryan, dmcphers, jhadvig, lxia
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1054697 (view as bug list)		Environment:
Last Closed:	2014-01-30 00:48:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1054697

Description Meng Bo 2013-10-10 06:44:28 UTC

Description of problem:
Create scalable app with empty git repo will return the following warning message twice.

"An empty Git repository has been created for your application.  Use 'git push' to add your code."

Version-Release number of selected component (if applicable):
devenv-stage_491

How reproducible:
always

Steps to Reproduce:
1.Create scalable app with empty git repo
# rhc create-app foo php-5 -s --from-code="empty"


Actual results:
The warning message will show twice.
# rhc create-app foo php-5.3 -s --from-code="empty"

Application Options
-------------------
  Domain:      bmengdev
  Cartridges:  php-5.3
  Source Code: empty
  Gear Size:   default
  Scaling:     yes

Creating application 'foo' ... 
An empty Git repository has been created for your application.  Use 'git push' to add your code.An empty Git repository has been created for your application.  Use 'git push' to add your code.
done


Expected results:
Should not show the duplicate messages.

Additional info:
There is no such issue for non-scalable app.

Comment 1 Jakub Hadvig 2013-11-04 16:54:02 UTC

Fixed the bug by moving the massage after the app creation.
Had to modify rhc and also origin-server.

part 1 - https://github.com/openshift/origin-server/pull/4077
part 2 - https://github.com/openshift/rhc/pull/499

Comment 2 Chris Ryan 2013-12-09 15:22:45 UTC

I'm experiencing this behavior on the latest devenv_4111 (ami-aba18cc2):

rhc app create app1 php-5.3 --from-code empty -s -l cryan -p 'redhat' --insecure --server ec2-54-224-225-5.compute-1.amazonaws.com
      Application Options
      -------------------
        Domain:      w11dic
        Cartridges:  php-5.3
        Source Code: empty
        Gear Size:   default
        Scaling:     yes
      
      Creating application 'app1' ... An empty Git repository has been created for your application.  Use 'git push' to add your code.An empty Git repository has been created for your application.  Use 'git push' to add your code.

Comment 3 openshift-github-bot 2013-12-10 14:21:31 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/fe05c3bdd3f968d965311b56c29e6520df51cb4a
Bug 1017536 - Duplication warning messages when creating scalable app with empty git repo

Comment 4 Jakub Hadvig 2013-12-10 15:03:51 UTC

Fixed and merged

PR: https://github.com/openshift/origin-server/commit/fe05c3bdd3f968d965311b56c29e6520df51cb4a

Comment 5 Liang Xia 2013-12-11 07:16:58 UTC

Verified on devenv_4120.

# rhc create-app foo php-5 -s --from-code="empty" --no-git --no-dns
Using php-5.3 (PHP 5.3) for 'php-5'

Application Options
-------------------
Domain:      lxia
Cartridges:  php-5.3
Source Code: empty
Gear Size:   default
Scaling:     yes

Creating application 'foo' ... An empty Git repository has been created for your application.  Use 'git push' to add your code.
done


Your application 'foo' is now available.

  URL:        http://foo-lxia.dev.rhcloud.com/
  SSH to:     52a81000351e49cff10001a1.rhcloud.com
  Git remote: ssh://52a81000351e49cff10001a1.rhcloud.com/~/git/foo.git/

Run 'rhc show-app foo' for more details about your app.