Bug 1017655
| Summary: | Web services configuration validation errors | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise Application Platform 6 | Reporter: | Petr Sakař <psakar> |
| Component: | Web Console | Assignee: | Heiko Braun <hbraun> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Pavel Jelinek <pjelinek> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.2.0 | CC: | brian.stansberry, hbraun, hpehl, jkudrnac, kkhan, nobody, pjelinek, rsvoboda |
| Target Milestone: | ER1 | ||
| Target Release: | EAP 6.4.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
In previous releases of JBoss EAP 6, invalid values for *WSDL Host*, *WSDL Port* and *WSDL Secure Port* under Profiles > Web > Web Services were not rejected by the web console.
This issue has been resolved in this release which honors the validation rules from the management model. Incorrect values are no longer saved.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-08-19 12:38:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1027254 | ||
| Bug Blocks: | 1176535 | ||
Setting this from high to medium as no real harm is caused by the invalid input. To address this, we're working on a more general approach, which will take the validation rules from the management model into account. Once in place all forms will benefit from that. @Harald If you are clearing the flag can you please comment why the issue does not require to be documented when it is not fixed for GA ? Sorry Petr, you're right. Added a value for "Doc Text" Modified Doc Text content and marked for inclusion in the 6.2 Release Notes document. Verified all described cases are fixed for EAP-6.3.0.DR1 Execuse me for mistake - validation is still not working property (it fails with unknown error) Though situation is better because values are not saved anymore, so user can not save form with invalid values Moving to 6.4 as the issue is still valid for 6.3 In general this issue is related to BZ1027254 Should this still remain in POST state? WSDL host field is still missing validation in 6.4.DR12 What kind of validation error? According to /subsystem=webservices:read-resource-description wsdl-host is nilable and not required. So setting the host in the console to an empty string will set the wsdl-host to undefined. Regarding ports you are correctly not allowed by client to save values outside "min" => 1L, "max" => 2147483647L. But regarding WSDL Host you are not warned by the client if you enter invalid hostname (e.g. asjlk@$#@$@#123321"""FGS::::::fsdgfd from the bug description), there is just Unknown error in messages and value seems saved until you leave and come back to #webservices page or refresh the browser. We do not provide a special validator for WSDL hosts. However I fixed the issue that the erroneous wsdl host is not replaced by the original host after a server side error. Verified for EAP 6.4.0.ER1 |
Description of problem: values user can enter are not correctly validated for wsdl host, wsdl port and wsdl secure port Version-Release number of selected component (if applicable): 6.2.0.ER5 How reproducible: always Steps to Reproduce: (every case starts with *) * WSDL port - set to zero - user can save the form, but Uknown error appears at the upper left corner, user has to click it otherwise can not continue Internal Server Error { "outcome" => "failed", "result" => { "step-1" => { "outcome" => "failed", "rolled-back" => true }, "step-2" => { "outcome" => "failed", "failure-description" => "JBAS014708: 0 is an invalid value for parameter wsdl-port. A minimum value of 1 is required", "rolled-back" => true } }, "failure-description" => {"JBAS014653: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-2" => "JBAS014708: 0 is an invalid value for parameter wsdl-port. A minimum value of 1 is required"}}, "rolled-back" => true, "response-headers" => {"process-state" => "reload-required"} } from now on 0 is displayed as port value * WSDL port - set to big number 9876543210987654, user is informed operation was successfull, but value is not changed * WSDL host - set to wrong host name (eg. asjlk@$#@$@#123321"""FGS::::::fsdgfd), form is saved, no error issued, value not changed * WSDL host - set to ${jboss-safsafsafasf-*} - internal error Unknown error Unexpected HTTP response: 500 Request { "operation" => "composite", "address" => [], "steps" => [{ "address" => [("subsystem" => "webservices")], "operation" => "write-attribute", "name" => "wsdl-host", "value" => expression "${jboss-safsafsafasf-*}" }] } Response Internal Server Error { "outcome" => "failed", "result" => {"step-1" => { "outcome" => "failed", "failure-description" => "JBAS014802: Cannot resolve expression 'expression \"${jboss-safsafsafasf-*}\"' -- java.lang.IllegalStateException: Failed to resolve expression: ${jboss-safsafsafasf-*}", "rolled-back" => true }}, "failure-description" => {"JBAS014653: Composite operation failed and was rolled back. Steps that failed:" => {"Operation step-1" => "JBAS014802: Cannot resolve expression 'expression \"${jboss-safsafsafasf-*}\"' -- java.lang.IllegalStateException: Failed to resolve expression: ${jboss-safsafsafasf-*}"}}, "rolled-back" => true, "response-headers" => {"process-state" => "reload-required"} } * WSDL host - set to ${jboss.bind.address:*} - internal error reported Actual results: user can save form with invalid values Expected results: user can not save form with invalid value of port (0) if user saves form with invalid hostname, error is reported internal errors related to entered values or their format are converted and presented Additional info: