Bug 1017660

Summary: /usr/libexec/qemu-bridge-helper is missing its setuid bit
Product: [Fedora] Fedora Reporter: Matthew Booth <mbooth>
Component: qemuAssignee: Fedora Virtualization Maintainers <virt-maint>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: amit.shah, berrange, cfergeau, crobinso, dwmw2, itamar, pbonzini, rjones, scottt.tw, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: qemu-1.4.2-13.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-15 20:30:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matthew Booth 2013-10-10 10:01:01 UTC
Description of problem:
/usr/libexec/qemu-bridge-helper is intended to be installed setuid. It allows non-privileged qemu instances to connect to an existing bridge. It is currently missing its setuid bit:

$ ls -la /usr/libexec/qemu-bridge-helper 
-rwxr-xr-x. 1 root root 15376 Sep 25 07:12 /usr/libexec/qemu-bridge-helper

The spec file does:
chmod u+s $RPM_BUILD_ROOT%{_libexecdir}/qemu-bridge-helper
...
%{_libexecdir}/qemu-bridge-helper

I believe this fails because it is built in a mock chroot. It presumably needs an explit %attr in %files for this to work.

Version-Release number of selected component (if applicable):
qemu-common-1.4.2-11.fc19.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Ensure /etc/qemu/bridge.conf contains 'allow virbr0'.
2. Create a libvirt 'session' guest as an unprivileged user.
3. Configure networking with:
    <interface type='bridge'>
      <source bridge='virbr0'/>
    </interface>
4. Start the guest

Actual results:
Permission denied

Expected results:
Guest connected to the virbr0 bridge

Comment 1 Cole Robinson 2013-10-31 21:50:35 UTC
Hmm, this is correct in f18 but not f19+, must need some RPM tweak

Comment 2 Fedora Update System 2013-11-06 01:27:11 UTC
qemu-1.4.2-13.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qemu-1.4.2-13.fc19

Comment 3 Fedora Update System 2013-11-07 03:39:32 UTC
Package qemu-1.4.2-13.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing qemu-1.4.2-13.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-20824/qemu-1.4.2-13.fc19
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2013-11-15 20:30:51 UTC
qemu-1.4.2-13.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.