Bug 1018044

Summary: unexpanded systemd-macros in rpm-scriptlets
Product: [Fedora] Fedora Reporter: Ralf Corsepius <rc040203>
Component: ipmiutilAssignee: Andy Cress <arcress>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 20CC: arcress, iamdexpl
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-06-30 01:24:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ralf Corsepius 2013-10-11 04:50:09 UTC
Description of problem:

ipmiutil for Fedora >= 20 contains broken rpm-scriptlets,
which contain unexpanded systemd-macros:

# rpm -q --scripts -p ipmiutil-2.9.1-2.fc20.i686.rpm 
...
postinstall scriptlet (using /bin/sh):
...
%systemd_post  ipmiutil_evt.service
%systemd_post  ipmiutil_asy.service
%systemd_post  ipmiutil_wdt.service
%systemd_post  ipmi_port.service
preuninstall scriptlet (using /bin/sh):
...
%systemd_preun  ipmiutil_evt.service
%systemd_preun  ipmiutil_asy.service
%systemd_preun  ipmiutil_wdt.service
%systemd_preun  ipmi_port.service
...
postuninstall scriptlet (using /bin/sh):
if [ -x /bin/systemctl ]; then
%systemd_postun_with_restart  ipmi_port.service
   if [ -f %{_unitdir}/ipmiutil_evt.service ]; then
      rm -f %{_unitdir}/ipmiutil_evt.service 
      rm -f %{_unitdir}/ipmiutil_asy.service 
      rm -f %{_unitdir}/ipmiutil_wdt.service 
      rm -f %{_unitdir}/ipmi_port.service    
...

Additional info:
- The cause of this issue is the spec missing a BR: systemd to pull-in the
necessary systemd.macros.
- These unexpanded systemd macros may cause yum update failures, leaving behind
duplicate entries in rpmdb.

Comment 1 Andy Cress 2014-11-25 16:22:58 UTC
This was added to the ipmiutil.spec file for rawhide/epel6 and upstream in ipmiutil-2.9.3 (03/28/2014). 

03/28/2014 ARCress ipmiutil-2.9.3  changes
  doc/ipmiutil.spec   - add 'BuildRequires: systemd' if Fedora >= 15

Comment 2 Vadim Raskhozhev 2015-02-21 22:35:46 UTC
ipmiutil-2.9.1-4.fc21 has

      cp -f ${scr_dir}/ipmiutil_evt.service %{_unitdir}
      cp -f ${scr_dir}/ipmiutil_asy.service %{_unitdir}
      cp -f ${scr_dir}/ipmiutil_wdt.service %{_unitdir}
      cp -f ${scr_dir}/ipmi_port.service    %{_unitdir}

in its install script, which makes a file named /%{_unitdir}

Comment 3 Andy Cress 2015-04-06 16:35:08 UTC
I'm concerned that the fix to add the BuildRequires: systemd from 11/25/2014 for 2.9.3 didn't get merged into fc21.

Comment 4 Fedora End Of Life 2015-05-29 09:33:19 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora End Of Life 2015-06-30 01:24:01 UTC
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.