Bug 1018057
| Summary: | Review Request: golang-googlecode-goprotobuf - Go support for Google protocol buffers | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lokesh Mandvekar <lsm5> |
| Component: | Package Review | Assignee: | Matthew Miller <mattdm> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jkeck, lacypret, lemenkov, lsm5, mattdm, notting, package-review, tdawson, vbatts |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | mattdm:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | golang-googlecode-goprotobuf-0-0.14.gitefd7476.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-03 17:56:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1018477, 1018540 | ||
|
Description
Lokesh Mandvekar
2013-10-11 06:09:17 UTC
I do not suppose there is any harm in having the Provides: include the /testdata directories. Often these directories only have *_test.go source (if any source at all), so they would not be import'able. (In reply to Lokesh Mandvekar from comment #0) > Note: This package uses code.google.com/p/goprotobuf . There's also > code.google.com/p/protobuf, but I'm guessing the distinction is clear > because of the _golang_ in the package name I think it's better to leave the extra "go" in there -- it makes it more clear even if it's a bit unwieldy. Also matches what Debian is doing, where they use golang-godebiancontrol as an example. (On the other hand, they leave out the full path unless there's a conflict. I think what we're doing with always including it (the "googlecode" part) is better because it's basically just coincidence which one we package first if there are overlaps. > Also, should this block Bug 1005504 (already closed) ? No, that ship has sailed. :) I filed bug #1018007 for these. It looks like this package has two parts: goprotobuf/proto, the library, and goprotobuf/protoc-gen-go, a protocol compiler plugin. I _think_ etcd just needs the former, and already has its code generated. I think we probably should include both, possibly as different subpackages. Or, maybe we keep the goprotobuf/proto part in the devel package and build protoc-gen-go as part of the base package (which would then be arch-specific because protoc-gen-go is a binary). %changelog * Sat Oct 12 2013 Lokesh Mandvekar <lsm5> 0-0.2.hg61664b8425f3 - compiler plugin in archful base package - libraries in noarch (except rhel6) devel subpackage Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-goprotobuf.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-goprotobuf-0-0.2.hg61664b8425f3.fc21.src.rpm $ rpmlint RPMS/x86_64/golang-googlecode-goprotobuf-0-0.2.hg61664b8425f3.fc21.x86_64.rpm golang-googlecode-goprotobuf.x86_64: W: unstripped-binary-or-object /usr/bin/protoc-gen-go golang-googlecode-goprotobuf.x86_64: E: statically-linked-binary /usr/bin/protoc-gen-go golang-googlecode-goprotobuf.x86_64: W: no-manual-page-for-binary protoc-gen-go 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Note: 1. Should the docs go with base package or devel subpackage? (currently going with base) 2. with base package:- Requires: protobuf (not entirely sure) 3. Installing only the binary and not the .a archives (for now) 4. Current location of protoc-gen-go binary is /usr/bin, but README suggests $GOPATH/bin (In reply to Vincent Batts from comment #1) > I do not suppose there is any harm in having the Provides: include the > /testdata directories. Often these directories only have *_test.go source > (if any source at all), so they would not be import'able. sending new release with testdata removed, in a bit. %changelog * Sat Oct 12 2013 Lokesh Mandvekar <lsm5> 0-0.3.hg61664b8425f3 - testdata directories excluded Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-goprotobuf.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-goprotobuf-0-0.3.hg61664b8425f3.fc21.src.rpm > Note: 1. Should the docs go with base package or devel subpackage? > (currently going with base) Base is okay if the devel package depends on the base. (Which it might as well.) > 2. with base package:- Requires: protobuf (not entirely sure) Yes, because it doesn't make sense without. > 3. Installing only the binary and not the .a archives (for now) Right. > 4. Current location of protoc-gen-go binary is /usr/bin, but README suggests > $GOPATH/bin I tested it and that's okay. It just needs to be in the developer's $PATH ultimately. Also note that this one is a dependency of go-raft, not etcd directly. (That doesn't affect this spec file, just noting.) This one looks good except either
Option A: The -devel package should Require the base package. (Requires: %{name} = %{version}-%{release})
Option B: Since there's no real hard requirement, don't do that, but instead include the documentation in the devel package as well as in the base.
> Option B: Since there's no real hard requirement, don't do that, but instead > include the documentation in the devel package as well as in the base. -- Choosing this. %changelog * Mon Oct 14 2013 Lokesh Mandvekar <lsm5> 0-0.4.hg61664b8425f3 - defattr removed - docs included in base and devel packages Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-goprotobuf.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-goprotobuf-0-0.4.hg61664b8425f3.fc21.src.rpm Review passed, with the caveat that Go packaging guidelines are still in draft form and so we may need to update this.
Also, as I'm looking, I think it'd be good to have the base package description be
This package provides support for protocol buffers in the form of a protocol
compiler plugin which generates Go source files that, once compiled, can access
and manage protocol buffers.
Install %{name}-devel for the associated support library.
and then for devel
This package provides a library that implements run-time support for
encoding (marshaling), decoding (unmarshaling), and accessing protocol
buffers in the Go language.
Install %{name} for the related protocol compiler plugin.
%changelog * Mon Oct 14 2013 Lokesh Mandvekar <lsm5> 0-0.4.hg61664b8425f3 - description update Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-googlecode-goprotobuf.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-googlecode-goprotobuf-0-0.5.hg61664b8425f3.fc21.src.rpm New Package SCM Request ======================= Package Name: golang-googlecode-goprotobuf Short Description: Go support for Google protocol buffers Owners: lsm5 Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). golang-googlecode-goprotobuf-0-0.6.hg61664b8425f3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.6.hg61664b8425f3.fc20 golang-googlecode-goprotobuf-0-0.6.hg61664b8425f3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.6.hg61664b8425f3.el6 golang-googlecode-goprotobuf-0-0.6.hg61664b8425f3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.6.hg61664b8425f3.fc19 golang-googlecode-goprotobuf-0-0.6.hg61664b8425f3.el6 has been pushed to the Fedora EPEL 6 testing repository. golang-googlecode-goprotobuf-0-0.7.hg61664b8425f3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.7.hg61664b8425f3.fc20 golang-googlecode-goprotobuf-0-0.7.hg61664b8425f3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.7.hg61664b8425f3.el6 Package Change Request ====================== Package Name: golang-googlecode-goprotobuf InitialCC: golang-sig Done. golang-googlecode-goprotobuf-0-0.7.hg61664b8425f3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.7.hg61664b8425f3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: golang-googlecode-goprotobuf New Branches: epel7 Owners: tdawson maxamillion Git done (by process-git-requests). golang-googlecode-goprotobuf-0-0.10.git7f07925.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.10.git7f07925.fc20 golang-googlecode-goprotobuf-0-0.10.git7f07925.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.10.git7f07925.fc21 golang-googlecode-goprotobuf-0-0.10.git7f07925.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.10.git7f07925.el6 golang-googlecode-goprotobuf-0-0.11.git7f07925.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.11.git7f07925.fc20 golang-googlecode-goprotobuf-0-0.11.git7f07925.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.11.git7f07925.fc21 golang-googlecode-goprotobuf-0-0.11.git7f07925.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.11.git7f07925.el6 golang-googlecode-goprotobuf-0-0.12.git7f07925.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.12.git7f07925.fc20 golang-googlecode-goprotobuf-0-0.12.git7f07925.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.12.git7f07925.fc21 golang-googlecode-goprotobuf-0-0.12.git7f07925.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.12.git7f07925.el6 golang-googlecode-goprotobuf-0-0.11.git7f07925.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.11.git7f07925.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.12.git7f07925.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.12.git7f07925.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.12.git7f07925.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.fc20 golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.fc21 golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.fc22 golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.el6 golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.13.gitc22ae3c.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.14.gitefd7476.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.14.gitefd7476.fc22 golang-googlecode-goprotobuf-0-0.14.gitefd7476.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.14.gitefd7476.fc21 golang-googlecode-goprotobuf-0-0.14.gitefd7476.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.14.gitefd7476.fc20 golang-googlecode-goprotobuf-0-0.14.gitefd7476.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-googlecode-goprotobuf-0-0.14.gitefd7476.el6 golang-googlecode-goprotobuf-0-0.14.gitefd7476.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.14.gitefd7476.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.14.gitefd7476.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. golang-googlecode-goprotobuf-0-0.14.gitefd7476.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |