Bug 1018090

Summary: Review Request: python-argcomplete - Bash tab completion for argparse
Product: [Fedora] Fedora Reporter: Dale Macartney <dbmacartney>
Component: Package ReviewAssignee: Peter Robinson <pbrobinson>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: gspurgeon, package-review, pbrobinson
Target Milestone: ---Flags: pbrobinson: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-11-25 07:47:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1018092    

Description Dale Macartney 2013-10-11 08:00:31 UTC
SPEC: http://dbmacartney.fedorapeople.org/python-argcomplete/python-argcomplete.spec
SRPM: http://dbmacartney.fedorapeople.org/python-argcomplete/python-argcomplete-0.6.3-1.fc19.src.rpm


Description:
Argcomplete provides easy, extensible command line tab completion of
arguments for your Python script.

It makes two assumptions:

 * You're using bash as your shell
 * You're using argparse to manage your command line arguments/options

Argcomplete is particularly useful if your program has lots of
options or subparsers, and if your program can dynamically suggest
completions for your argument/option values (for example, if the user
is browsing resources over the network).

Comment 1 Dale Macartney 2013-10-11 08:08:28 UTC
koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6049657

Comment 2 Peter Robinson 2013-10-11 08:10:24 UTC
As Dale's sponsor I'll review this

Comment 3 Peter Robinson 2013-10-15 10:16:01 UTC
Mostly fine. The only blocker here is the lack of the included license file but that's an easy fix.

+ rpmlint output

rpmlint python-argcomplete-0.6.3-1.fc20.noarch.rpm python-argcomplete-0.6.3-1.fc20.src.rpm python-argcomplete.spec 
python-argcomplete.noarch: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse
python-argcomplete.noarch: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse
python-argcomplete.noarch: W: spelling-error %description -l en_US subparsers -> submerse
python-argcomplete.noarch: W: no-manual-page-for-binary activate-global-python-argcomplete
python-argcomplete.noarch: W: no-manual-page-for-binary python-argcomplete-check-easy-install-script
python-argcomplete.noarch: W: no-manual-page-for-binary register-python-argcomplete
python-argcomplete.src: W: spelling-error Summary(en_US) argparse -> sparse, parsec, parse
python-argcomplete.src: W: spelling-error %description -l en_US argparse -> sparse, parsec, parse
python-argcomplete.src: W: spelling-error %description -l en_US subparsers -> submerse
2 packages and 1 specfiles checked; 0 errors, 9 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ latest version packaged

- %doc includes license file
  Needs to include the LICENSE.rst in %doc
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  bb87bddc65f6df1622a3eac7d1b98c95 argcomplete-0.6.3.tar.gz
+ package successfully builds on at least one architecture
+ tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr
+ package owns all directories it creates
n/a no duplicate files in %files
+ Package perserves timestamps on install
+ Permissions on files must be set properly 
+ %defattr line
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime 
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
+ the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
n/a Package should have man files

Comment 5 Peter Robinson 2013-10-15 12:22:56 UTC
Licence file added. 

The is APPROVED!

Comment 6 Dale Macartney 2013-10-15 12:27:03 UTC
New Package GIT Request
=======================
Package Name: python-argcomplete
Short Description: Bash tab completion for argparse
Owners: dbmacartney
Branches: F-19 F-18 EL-6
InitialCC:

Comment 7 Gwyn Ciesla 2013-10-15 12:43:17 UTC
Email address dale is not a valid bugzilla email
address.  Either make a bugzilla account with that email address or change
your email address in the Fedora Account System
https://admin.fedoraproject.org/accounts/ to a valid bugzilla email address
and try again.

Comment 8 Dale Macartney 2013-10-15 13:19:14 UTC
Accounts corrected!

Comment 9 Dale Macartney 2013-10-15 14:40:14 UTC
New Package GIT Request
=======================
Package Name: python-argcomplete
Short Description: Bash tab completion for argparse
Owners: dbmacartney
Branches: F-19 F-18 EL-6
InitialCC:

Comment 10 Gwyn Ciesla 2013-10-15 15:00:43 UTC
Git done (by process-git-requests).

Comment 11 Dale Macartney 2013-10-16 09:19:14 UTC
Package Change Request
======================
Package Name: python-argcomplete
New Branches: F-20
Owners: dbmacartney

Comment 12 Gwyn Ciesla 2013-10-16 12:29:48 UTC
Git done (by process-git-requests).

Comment 13 Dale Macartney 2014-09-12 11:01:43 UTC
Package Change Request
=======================
Package Name: python-argcomplete
Short Description: Bash tab completion for argparse
Owners: dbmacartney
Branches: EPEL7
InitialCC:

Comment 14 Gwyn Ciesla 2014-09-12 12:06:35 UTC
Git done (by process-git-requests).

The branch is epel7, not EPEL7.