Bug 1018349

Summary:	rhqclt does not propagate RHQ_CONTROL_ADDITIONAL_JAVA_OPTS to JON VM
Product:	[JBoss] JBoss Operations Network	Reporter:	Viet Nguyen <vnguyen>
Component:	Launch Scripts	Assignee:	RHQ Project Maintainer <rhq-maint>
Status:	CLOSED NOTABUG	QA Contact:	Mike Foley <mfoley>
Severity:	medium	Docs Contact:
Priority:	urgent
Version:	JON 3.2	CC:	lzoubek, mazz
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-07 15:32:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Viet Nguyen 2013-10-11 18:24:26 UTC

I wanted to customize server jvm settings with RHQ_CONTROL_ADDITIONAL_JAVA_OPTS="-verbosegc -XX:+PrintGCDateStamps -XX:+PrintGCTimeStamps -XX:+PrintGCDetails -Xloggc:/tmp/rhq-server-gc.log"

However gc log file only shows a summary of gc activities which I suspect belongs to rhqctl process not jon server's. 

Build
ER3

How reproducible:
100%

Steps to Reproduce:
1.  export RHQ_CONTROL_ADDITIONAL_JAVA_OPTS=-Dfoobar
2.  rhqctl restart (or start)
3.  ps -ef|grep jav[a]

Actual results:

No sight of -Dfoobar in jon server vm arguments 


Expected results:


Additional info:

Comment 1 Viet Nguyen 2013-10-11 18:47:40 UTC

Upon further investigation I found the old RHQ_AGENT_ADDITIONAL_JAVA_OPTS and RHQ_SERVER_ADDITIONAL_JAVA_OPTS still work as designed.  Since rhqclt is now the one stop script we should include the usage for RHQ_SERVER.. and RHQ_AGENT..

Comment 2 Simeon Pinder 2013-11-08 14:41:06 UTC

Moving to unspecified target milestone as only JON 3.2.0 'blockers'(https://url.corp.redhat.com/bz-jon32-blockers-list-notmodified-nodocs) will make it into subsequent builds after ER5.

Comment 4 Libor Zoubek 2014-01-07 14:50:09 UTC

We'd need to get this fixed at least in RHQ, it's blocking our code coverage job. Thanks

Comment 5 John Mazzitelli 2014-01-07 15:03:16 UTC

these should not propogate to the JON VM - the name RHQ_CONTROL_... means its only for the rhqctl java code (that is, its only for the JVM for the control script).

Comment 6 John Mazzitelli 2014-01-07 15:06:37 UTC

However, I think what this BZ is asking for is - now that we have this wrapper JVM thingy "rhqctl" - we probably need a way for propogate custom environment settings to the server / agent JVM right?

Doesn't setting the normal env vars still work? RHQ_SERVER_xxx and RHQ_AGENT_xxx ??? If they still work, then this BZ can be closed as "working as expected"

If there is no way to customize the server and agent JVM through those normal env var mechanisms, we need to figure out how to do so.

Comment 7 Libor Zoubek 2014-01-07 15:32:59 UTC

I thought I was hitting this bug, but it turned out I'm not. As RHQ_CONTROL_ are suposed to be for rhqctl JVM and RHQ_AGENT_ and RHQ_SERVER_ work as expected, closing