Bug 1018384

This is a package revival. According to dead.package:

This package was retired due to no active owner on 2011-02-23

I will review this.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
1. Buildroot, rm -rf $BUILDROOT and %clean are present: is it your intention to also package for EL5?
    If not, please remove them
2. Please use just one style of variables: either $BUILDROOT style or %{_man_dir} style
3. Please move the desktop file to a source file instead of writing it from the spec
4. Needs the explicit perl requires: https://fedoraproject.org/wiki/Packaging:Perl#Versioned_MODULE_COMPAT_Requires
5. You should ask upstream to add license text
6. Please add justification to patches, and try to send them upstream
7. Please add info or url on how to get Source tarball
8. Please use %global instead of %define
9. Please fix the locales: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Handling_Locale_Files
10. Final provides seem insane: why is it providing perl(CA), perl(GUI), amongst others?


===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v2 or later) (with incorrect FSF address)", "Unknown or generated".
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: The spec file handles locales properly.
[!]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[!]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
     file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[!]: Package contains the mandatory BuildRequires and Requires:.
     Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
     $version)) missing?

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[!]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[!]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[!]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define snapshot 20070611
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[-]: Fully versioned dependency in subpackages if applicable.
[!]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: tinyca2-0.7.6-0.8.20070611.fc21.noarch.rpm
          tinyca2-0.7.6-0.8.20070611.fc21.src.rpm
tinyca2.noarch: W: invalid-url URL: http://tinyca.sm-zone.net/ <urlopen error timed out>
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/TCONFIG.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/OpenSSL.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/WORDS.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/REQ.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/bin/tinyca2
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/CALLBACK.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/X509_browser.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/CERT.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/X509_infobox.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/TCONFIG.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/CA.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/HELPERS.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/HELPERS.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/KEY.pm
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/sv/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: desktopfile-without-binary /usr/share/applications/Foobar-tinyca2.desktop /usr/bin/tinyca2
tinyca2.src: W: spelling-error Summary(en_US) openssl -> slope
tinyca2.src: W: spelling-error %description -l en_US openssl -> slope
tinyca2.src: W: invalid-url URL: http://tinyca.sm-zone.net/ <urlopen error timed out>
tinyca2.src: W: invalid-url Source0: tinyca2-0.7.6-20070611.tar.bz2
2 packages and 0 specfiles checked; 15 errors, 11 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint tinyca2
tinyca2.noarch: W: invalid-url URL: http://tinyca.sm-zone.net/ <urlopen error timed out>
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/TCONFIG.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/OpenSSL.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/WORDS.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/REQ.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/bin/tinyca2
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/CALLBACK.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/X509_browser.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/CERT.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/X509_infobox.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/TCONFIG.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/CA.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI/HELPERS.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/GUI.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/HELPERS.pm
tinyca2.noarch: E: incorrect-fsf-address /usr/share/tinyca2/KEY.pm
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/cs/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/de/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/es/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/fr/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: file-not-in-%lang /usr/share/locale/sv/LC_MESSAGES/tinyca2.mo
tinyca2.noarch: W: desktopfile-without-binary /usr/share/applications/Foobar-tinyca2.desktop /usr/bin/tinyca2
1 packages and 0 specfiles checked; 15 errors, 7 warnings.
# echo 'rpmlint-done:'



Requires
--------
tinyca2 (rpmlib, GLIBC filtered):
    /usr/bin/perl
    config(tinyca2)
    openssl
    perl
    perl(CA)
    perl(CERT)
    perl(GUI)
    perl(GUI::CALLBACK)
    perl(GUI::HELPERS)
    perl(GUI::TCONFIG)
    perl(GUI::WORDS)
    perl(GUI::X509_browser)
    perl(GUI::X509_infobox)
    perl(Getopt::Long)
    perl(Gtk2)
    perl(Gtk2::SimpleMenu)
    perl(HELPERS)
    perl(IO::Select)
    perl(IPC::Open3)
    perl(KEY)
    perl(Locale::gettext)
    perl(MIME::Base64)
    perl(OpenSSL)
    perl(POSIX)
    perl(REQ)
    perl(TCONFIG)
    perl(Time::Local)
    perl(strict)
    perl-Gtk2



Provides
--------
tinyca2:
    config(tinyca2)
    perl(CA)
    perl(CERT)
    perl(GUI)
    perl(GUI::CALLBACK)
    perl(GUI::HELPERS)
    perl(GUI::TCONFIG)
    perl(GUI::WORDS)
    perl(GUI::X509_browser)
    perl(GUI::X509_infobox)
    perl(HELPERS)
    perl(KEY)
    perl(OpenSSL)
    perl(REQ)
    perl(TCONFIG)
    tinyca
    tinyca2



This was built with koji instead of mock because of a broken local mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=6051991.


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review --prebuilt --name tinyca2
Buildroot used: fedora-19-x86_64
Active plugins: Generic, Shell-api, Perl
Disabled plugins: Java, C/C++, Python, SugarActivity, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

Spec URL: ftp://ftp.nohats.ca/tinyca2/tinyca2.spec
SRPM URL:ftp://ftp.nohats.ca/tinyca2/tinyca2-0.7.6-0.9.20070611.fc19.src.rpm

* Sat Oct 12 2013 Paul Wouters <pwouters> - 0.7.6-0.9.20070611
- cleanup macro style, remove el5 compat items, use global instead of define
- Clean vendor
- Fixup perl requires
- Fixup locale handling
- Preserve timestamps with install
- Fixup mixed tab/spaces

This addresses 1) 2) 4) 8) and 9)
For 5) 6) and 7) well, upstream has been dead since 2007 :) These patches are mostly to make things work on newer versions of perl.

3) Why should it be a separate file? (also this way if we change bindir again it remains working :)

10) I agree it is a bit silly. But its automatically generated based on where it is installed. Is it worth changing this? That would be a big change and upstream would never merge it in.

You have not removed all el5 compat items:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
and 
%install
rm -rf %{buildroot}


About 6: I know that upstream is dead, but could you add a comment to the spec where the respective patches are for? (or one comment "These are for perl compatibility")?


About 3: Sure. I thought you needed to have it in a seperate file, but going through the guidelines proved me wrong :)


10) Well, this could cause some serious breakage if some application says "Requires: Perl(GUI)", and the user gets tinyca2 instead of the package providing perl(GUI), so I think you would need to change that.
This is a known problem, and even has its own section in the Perl packaging guidelines on how to do this: https://fedoraproject.org/wiki/Packaging:Perl#Filtering_Requires_and_Provides

Spec URL: ftp://ftp.nohats.ca/tinyca2/tinyca2.spec
SRPM URL:ftp://ftp.nohats.ca/tinyca2/tinyca2-0.7.6-0.9.20070611.fc19.src.rpm

* Sun Oct 13 2013 Paul Wouters <pwouters> - 0.7.6-0.10.20070611
- Filter out bogus Requires/Provides
- clean some EL5 leftover items


It's now:

Provides: config(tinyca2) = 0.7.6-0.10.20070611.fc19 perl(CA) tinyca = 0.7.6-0.10.20070611.fc19 tinyca2 = 0.7.6-0.10.20070611.fc19

Requires: /usr/bin/perl perl(Getopt::Long) perl(Gtk2) perl(Gtk2::SimpleMenu) perl(IO::Select) perl(IPC::Open3) perl(Locale::gettext) perl(MIME::Base64) perl(OpenSSL) perl(Time::Local)

Looks fine to me, and all points indicated are fixed.

APPROVED

New Package SCM Request
=======================
Package Name: tinyca2
Short Description: TinyCA2 is a graphical tool written in Perl/Gtk to manage a small Certification Authority (CA) using openssl.

TinyCA supports
- creation and revocation of x509 - S/MIME certificates.
- PKCS#10 requests.
- exporting certificates as PEM, DER, TXT, and PKCS#12.
- server certificates for use in web servers, email servers, IPsec,
  and more.
- client certificates for use in web browsers, email clients, IPsec,
  and more.
- creation and management of SubCAs
Owners: pwouters
Branches: f20 f19 f18 el6
InitialCC:

The Short description field here should basically match the Summary: field in the .spec file and Subject of this review.  For example,
Short Description: TinyCA graphical openssl based CA

(though IMO, repeating the pkg name "TinyCA" here is redundant)

No FAS account for owner specified.

Jon Ciesle: There is an owner specified? pwouters?

(In reply to Patrick Uiterwijk from comment #11)
> Jon Ciesle: There is an owner specified? pwouters?

Ciesla*

The request is misformatted.  I think the long description being in the short description field is the problem.

https://fedoraproject.org/wiki/Package_SCM_admin_requests

Unsetting flag.

New Package SCM Request
=======================
Package Name: tinyca2
Short Description: TinyCA graphical openssl based CA
Owners: pwouters
Branches: f20 f19 f18 el6
InitialCC:

Oh, this is an unretirement.  I've unretired devel, please submit a Package
Change request for the other branches.  Sorry for the extra work.

Package Change Request
======================
Package Name: tinyca2
New Branches: f20 f19 f18 el6
Owners: pwouters
InitialCC:

Git done (by process-git-requests).

So... is someone going to build some rpms?

oops. totally missed the ball on this. rpms coming right up

Sorry to be a pest, but are the rpms available somewhere now? I don't see them anywhere...

There have been a few commits recently,
http://pkgs.fedoraproject.org/cgit/tinyca2.git/log/

but no (recent) builds have been made yet,
http://koji.fedoraproject.org/koji/packageinfo?packageID=3987

The builds are failing because tinyca2 seems to be manually blacklisted in the build system. I had pinged on #fedora-admin about this.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6265706

Descendants 	build

    buildSRPMFromSCM (/tinyca2:599f1d67fcf53c3dac58676950f618cc9a6449b1)

Waiting?	no
Awaited?	no
Priority	20
Weight	0.20
Result 	

BuildError: package tinyca2 is blocked for tag f20-updates-candidate
          

Output

To fix this, you should file a bug at https://fedorahosted.org/rel-eng/

done: https://fedorahosted.org/rel-eng/ticket/5841

Not blocked, rawhide build complete.

Thanks!