Bug 1018533

Summary: Review Request: golang-github-coreos-go-systemd - Go bindings to systemd socket activation, journal and D-BUS APIs
Product: [Fedora] Fedora Reporter: Lokesh Mandvekar <lsm5>
Component: Package ReviewAssignee: Matthew Miller <mattdm>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jkeck, lacypret, lemenkov, mattdm, notting, package-review, vbatts
Target Milestone: ---Keywords: Reopened
Target Release: ---Flags: mattdm: fedora-review+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: golang-github-coreos-go-systemd-0-0.3.git68bc612.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-29 03:33:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1018480, 1018523    

Description Lokesh Mandvekar 2013-10-13 01:19:21 UTC
Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-github-coreos-go-systemd.spec
SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-github-coreos-go-systemd-0-0.1.git68bc612.fc21.src.rpm

Description: 
Go bindings to systemd socket activation, journal and D-BUS APIs.

Fedora Account System Username: lsm5

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6054062

rpmlint SPECS/golang-github-coreos-go-systemd.spec SRPMS/golang-github-coreos-go-systemd-0-0.1.git68bc612.fc21.src.rpm RPMS/noarch/golang-github-coreos-go-systemd-devel-0-0.1.git68bc612.fc21.noarch.rpm
SPECS/golang-github-coreos-go-systemd.spec:37: W: setup-not-quiet
golang-github-coreos-go-systemd.src:37: W: setup-not-quiet
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 1 Matthew Miller 2013-10-14 17:25:34 UTC
Review passed. As with other Go packages, this is with the caveat that updates to the draft guidelines may require packaging changes in the near future.

Comment 2 Lokesh Mandvekar 2013-10-14 18:50:43 UTC
New Package SCM Request
=======================
Package Name: golang-github-coreos-go-systemd
Short Description: Go bindings to systemd socket activation, journal and D-BUS APIs
Owners: lsm5
Branches: f19 f20 el6
InitialCC:

Comment 3 Peter Lemenkov 2013-10-14 19:23:32 UTC
Btw defattr(...) directive should be removed. This isn't needed anymore since Fedora Core 6 / RHEL 5

Comment 4 Matthew Miller 2013-10-14 20:02:51 UTC
(In reply to Peter Lemenkov from comment #3)
> Btw defattr(...) directive should be removed. This isn't needed anymore
> since Fedora Core 6 / RHEL 5

I thought the EPEL guidelines still called for it, but I'm not seeing that now. The Fedora guidelines just mention it as not necessary (but also not forbidden). So, whatever Lokesh prefers.

Comment 5 Lokesh Mandvekar 2013-10-14 21:21:24 UTC
%changelog
* Mon Oct 14 2013 Lokesh Mandvekar <lsm5> 0-0.2.git68bc612
- provides golang("github.com/coreos/go-systemd")
- defattr removed


Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-github-coreos-go-systemd.spec
SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-github-coreos-go-systemd-0-0.2.git68bc612.fc21.src.rpm

Comment 6 Jens Petersen 2013-10-15 06:00:43 UTC
Git done (by process-git-requests).

(I think defattr is only needed for epel5.)

Comment 7 Fedora Update System 2013-10-16 03:56:30 UTC
golang-github-coreos-go-systemd-0-0.2.git68bc612.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-github-coreos-go-systemd-0-0.2.git68bc612.fc20

Comment 8 Fedora Update System 2013-10-16 04:01:33 UTC
golang-github-coreos-go-systemd-0-0.2.git68bc612.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/golang-github-coreos-go-systemd-0-0.2.git68bc612.fc19

Comment 9 Fedora Update System 2013-10-16 04:06:38 UTC
golang-github-coreos-go-systemd-0-0.2.git68bc612.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-github-coreos-go-systemd-0-0.2.git68bc612.el6

Comment 10 Fedora Update System 2013-10-17 18:04:20 UTC
golang-github-coreos-go-systemd-0-0.2.git68bc612.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 11 Fedora Update System 2013-10-19 00:10:04 UTC
golang-github-coreos-go-systemd-0-0.3.git68bc612.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-github-coreos-go-systemd-0-0.3.git68bc612.fc20

Comment 12 Fedora Update System 2013-10-19 00:19:41 UTC
golang-github-coreos-go-systemd-0-0.3.git68bc612.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/golang-github-coreos-go-systemd-0-0.3.git68bc612.fc19

Comment 13 Fedora Update System 2013-10-19 00:25:23 UTC
golang-github-coreos-go-systemd-0-0.3.git68bc612.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-github-coreos-go-systemd-0-0.3.git68bc612.el6

Comment 14 Peter Lemenkov 2013-10-23 11:06:48 UTC
Package Change Request
======================
Package Name: golang-github-coreos-go-systemd
InitialCC: golang-sig

Comment 15 Gwyn Ciesla 2013-10-23 14:11:23 UTC
Done.

Comment 16 Fedora Update System 2013-10-29 03:33:04 UTC
golang-github-coreos-go-systemd-0-0.3.git68bc612.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2013-11-03 17:57:26 UTC
golang-github-coreos-go-systemd-0-0.3.git68bc612.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2013-11-10 06:19:17 UTC
golang-github-coreos-go-systemd-0-0.3.git68bc612.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.