Bug 1018540
| Summary: | Review Request: golang-github-goraft-raft - A Go implementation of the Raft distributed consensus protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lokesh Mandvekar <lsm5> |
| Component: | Package Review | Assignee: | Matthew Miller <mattdm> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jkeck, lacypret, lemenkov, lsm5, mattdm, notting, package-review, tdawson, vbatts |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | mattdm:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | golang-github-goraft-raft-0-0.3.gite138889.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-10-29 03:48:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1018057 | ||
| Bug Blocks: | 1018479 | ||
|
Description
Lokesh Mandvekar
2013-10-13 03:27:19 UTC
packaging the upstream instead of the coreos fork Should have BuildRequires: golang-googlecode-goprotobuf-devel (Or the equivalent golang("[import path]") virtual provides.)
Actually should be Requires, not BuildRequires. So, the devel package should have
Requires: golang("code.google.com/p/goprotobuf/proto")
Eventually, we'll make RPM generate these automatically.
%changelog * Tue Oct 15 2013 Lokesh Mandvekar <lsm5> 0-0.2.gite138889 - requires goprotobuf Spec URL: http://lsm5.fedorapeople.org/rpmbuild/SPECS/golang-github-goraft-raft.spec SRPM URL: http://lsm5.fedorapeople.org/rpmbuild/SRPMS/golang-github-goraft-raft-0-0.2.gite138889.fc21.src.rpm Review passed, with the caveat that it may need to be updated as the Go packaging guidelines progress beyond draft form. Also, it wouldn't hurt to have a more descriptive description. But not a big deal for the review. %description This is a Go implementation of the Raft distributed consensus protocol. Raft is a protocol by which a cluster of nodes can maintain a replicated state machine. The state machine is kept in sync through the use of a replicated log. New Package SCM Request ======================= Package Name: golang-github-goraft-raft Short Description: A Go implementation of the Raft distributed consensus protocol Owners: lsm5 Branches: f19 f20 el6 InitialCC: Git done (by process-git-requests). golang-github-goraft-raft-0-0.3.gite138889.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-goraft-raft-0-0.3.gite138889.fc20 golang-github-goraft-raft-0-0.3.gite138889.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/golang-github-goraft-raft-0-0.3.gite138889.fc19 golang-github-goraft-raft-0-0.3.gite138889.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-goraft-raft-0-0.3.gite138889.el6 golang-github-goraft-raft-0-0.3.gite138889.el6 has been pushed to the Fedora EPEL 6 testing repository. Package Change Request ====================== Package Name: golang-github-goraft-raft InitialCC: golang-sig Done. golang-github-goraft-raft-0-0.3.gite138889.fc19 has been pushed to the Fedora 19 stable repository. golang-github-goraft-raft-0-0.3.gite138889.el6 has been pushed to the Fedora EPEL 6 stable repository. golang-github-goraft-raft-0-0.3.gite138889.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: golang-github-goraft-raft New Branches: epel7 Owners: tdawson maxamillion Git done (by process-git-requests). |