Bug 1018575
| Summary: | pmatop exceptions need better catching | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Frank Ch. Eigler <fche> |
| Component: | pcp | Assignee: | Nathan Scott <nathans> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 22 | CC: | fche, mbenitez, mgoodwin, nathans, pcp, scox |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 3.10.6-1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-08-13 16:56:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
sourceware.org/git/pcpfans.git scox/dev commit 77377f219088 Handle curses problems gracefully. Whenever a curses problem is encountered the above gives the error message: % pmatop Error in the curses module. Try running pmatop in a larger window. This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle. Changing version to '22'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22 pcp-3.10.5-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/pcp-3.10.5-1.fc22 pcp-3.10.5-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/pcp-3.10.5-1.fc21 pcp-3.10.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/pcp-3.10.5-1.fc20 pcp-3.10.5-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/pcp-3.10.5-1.el5 Package pcp-3.10.5-1.el5: * should fix your issue, * was pushed to the Fedora EPEL 5 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing pcp-3.10.5-1.el5' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6718/pcp-3.10.5-1.el5 then log in and leave karma (feedback). pcp-3.10.6-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/pcp-3.10.6-1.fc22 pcp-3.10.6-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/pcp-3.10.6-1.fc21 pcp-3.10.6-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/pcp-3.10.6-1.el5 pcp-3.10.6-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. pcp-3.10.6-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. pcp-3.10.6-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |
On a small gnome-terminal (measly 90x24), git pmatop (targeted to a machine with lots of disks/cpus) finds it easy to trigger curses errors, exiting the whole program. Easily reproducible: % python pmatop.py press random keys to evoke the online-help ditty, but get: Traceback (most recent call last): File "pmatop.py", line 771, in <module> status = curses.wrapper(main) # pylint: disable-msg=C0103 File "/usr/lib64/python2.7/curses/wrapper.py", line 43, in wrapper return func(stdscr, *args, **kwds) File "pmatop.py", line 748, in main stdscr.addstr ("Invalid command %s\nType 'h' to see a list of valid commands" % (cmd)) File "pmatop.py", line 144, in addstr self.so_stdscr.addstr (str) _curses.error: addstr() returned ERR In general, these python programs (pmatop and pmcollectl) need more systematic exception catching; maybe a full-fledged curses error-reporting screen?