Bug 1018862

Summary:	Review Request: perl-File-SearchPath - Search for a file in an environment variable path
Product:	[Fedora] Fedora	Reporter:	Kostas Georgiou <k.georgiou>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	perl-File-SearchPath-0.06-2.fc18	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-14 08:45:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Kostas Georgiou 2013-10-14 14:35:18 UTC

Spec URL: http://georgiou.fedorapeople.org//perl-File-SearchPath.spec
SRPM URL: http://georgiou.fedorapeople.org//perl-File-SearchPath-0.06-1.fc19.src.rpm

Description:
This module provides the ability to search a path-like environment variable
for a file (that does not necessarily have to be an executable).

Comment 1 Kostas Georgiou 2013-10-14 14:35:24 UTC

This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=6058658

Comment 2 Petr Šabata 2013-10-17 04:04:59 UTC

Taking the review.

Comment 3 Petr Šabata 2013-10-17 04:33:16 UTC

TODO: Remove lines 9, 31, 41, 42, and 45 (Buildroot, %buildroot removal, %clean section, and %defattr) from your SPEC.  Those have been obsolete for maybe 10 releases now.

TODO: Line 34 (removing of empty directories) is also unnecessary these days.  You may drop it too.

TODO: Buildrequire perl, called in spec
FIX: Buildrequire perl(base), ./lib/File/SearchPath.pm:34
FIX: Buildrequire perl(Carp), ./lib/File/SearchPath.pm:30
TODO: Buildrequire perl(Config), ./lib/File/SearchPath.pm:38, ./t/search.t:5
FIX: Buildrequire perl(Exporter), ./lib/File/SearchPath.pm:34
TODO: Buildrequire perl(strict), ./Build.PL:3, ./lib/File/SearchPath.pm:32
TODO: Buildrequire perl(vars), ./lib/File/SearchPath.pm:35
TODO: Buildrequire perl(warnings), ./Build.PL:4, ./lib/File/SearchPath.pm:31

Please, always go through the source, see what modules are used during the build phase, and BR them.

FIX: The license tag is wrong.  It should be GPLv2+.  See ./lib/File/SearchPath.pm.


Fix at least the points marked as FIX before submitting an updated package.

Comment 4 Kostas Georgiou 2013-10-17 11:52:33 UTC

Updated files with fixes for all TODO and FIX items.

Spec URL: http://georgiou.fedorapeople.org/perl-File-SearchPath.spec
SRPM URL: http://georgiou.fedorapeople.org/perl-File-SearchPath-0.06-2.fc21.src.rpm

Assuming that everything passes is it OK for the new package request to contain el6 even though it will be blocked by #1018330 or should be done as a seperate step once that Env::Path is available for epel-6?

Comment 5 Petr Šabata 2013-10-18 07:21:06 UTC

All defects fixed, approving.

Comment 6 Kostas Georgiou 2013-10-18 10:04:36 UTC

New Package SCM Request
=======================
Package Name: perl-File-SearchPath
Short Description: Search for a file in an environment variable path
Owners: georgiou
Branches: f18 f19 f20 el6
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2013-10-18 12:53:08 UTC

Git done (by process-git-requests).

Comment 8 Petr Šabata 2014-04-04 13:40:28 UTC

Ping. Have you pushed and built the package?

Comment 9 Petr Šabata 2015-05-14 08:45:27 UTC

This package is now maintained by Emmanuel Seyman.

If anybody's ever interested, the EPEL6 branch exists but is orphaned and nobody has ever built the package there.  Feel free to take it.

Closing.