Bug 1019156

Summary:	Missing input constraints for Pool sizes on Datasource setup screen
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Petr Kremensky <pkremens>
Component:	Installer	Assignee:	Miles Tjandrawidjaja <mtjandra>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Petr Kremensky <pkremens>
Severity:	high	Docs Contact:	Russell Dickenson <rdickens>
Priority:	unspecified
Version:	6.2.0	CC:	mtjandra, thauser
Target Milestone:	ER7
Target Release:	EAP 6.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-15 16:16:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Kremensky 2013-10-15 08:43:54 UTC

Description of problem:
 There should be numeric input validation for min and max pool size input fields on Datasource setup screen. User can add string as pool size now -> post-install configuration will fail.

Version-Release number of selected component (if applicable):
 EAP 6.2.0.ER5

How reproducible:
 Always

Steps to Reproduce:
 1. Start gui installer, use default values until you get into Post-Install Configuration screen.
 2. Select to Install JDBC driver and Datasource
 3. On Datasource setup screen enter "foo" as Min pool size and "bar" as Max pool size.
 4. Finish the installation

Actual results:
 Post-install configuration will fail, installation ends with failure message.

Expected results:
 Error dialo will appear once user push Next button on Datasource screen.

Additional info:
 It would be nice to have CLI operation results in post-install logs, so user could easily spot the cause of post-install configuration failure without manually reproducing all configuration steps. I'll create another BZ for this.

Comment 1 Petr Kremensky 2013-10-15 10:15:54 UTC

I am also able to enter empty Connection Url -> post-install configuration will fail as well.

Comment 2 Petr Kremensky 2013-10-15 11:42:53 UTC

And empty pool sizes.

Comment 3 Petr Kremensky 2013-10-15 12:31:35 UTC

I'll make a little summary here as this starts to be a little confusing.
Datasource Setup screen:
-- missing numeric validation:
- Min pool size 
- Max pool size
- min pool size can be greater than max pool size now!

-- missing empty validation
- Min pool size 
- Max pool size
- Security domain
- Username
- Password
- Connection URL

-- JNDI validation 
- JNDI name
- covered by BZ1019241

Comment 4 Miles Tjandrawidjaja 2013-10-15 15:44:17 UTC

Validation for pool sizes have been added
http://git.app.eng.bos.redhat.com/jbossas-installer.git/commit/?h=eap-6.2&id=f91b1d016c421e39f505f19f1cca78ed6a5ed620

Empty Validation has been added.
http://git.app.eng.bos.redhat.com/jbossas-installer.git/commit/?h=eap-6.2&id=0806230bcfaa01327357b9ce54154683e969a1b7

JNDI validation added via BZ1019241

Comment 5 Petr Kremensky 2013-10-18 10:22:35 UTC

I can still enter empty Recovery user and Recovery password -> post-installation fail. Also Values for default XA Properties can be empty.

Comment 6 Petr Kremensky 2013-10-18 12:08:14 UTC

Can you please also update pools input fields to accept only numeric values like it's on custom port input fields?

Comment 7 Miles Tjandrawidjaja 2013-10-18 18:30:23 UTC

Hello,

I have fixed validation for the User/Password fields I missed.
The XA Property validations are back.
Also updated fields for min/max pools so that you can only type in numeric values.

Comment 8 Petr Kremensky 2013-11-01 13:47:07 UTC

Verified on EAP 6.2.0.ER7 installer.