Bug 1019453 (sddm-kcm)
Summary: | Review Request: sddm-kcm - SDDM KDE configuration module | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Martin Bříza <mbriza> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | kevin, notting, package-review, rdieter |
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | sddm-kcm-0-0.1.20131114gitafdda33c.fc20 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-11-19 21:45:24 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 656997, 1007925 |
Description
Martin Bříza
2013-10-15 18:22:48 UTC
Initial comments: 1. replace %{_kde4_datadir}/kde4/apps/sddm-kcm/main.qml with %{_kde4_appsdir}/sddm-kcm/ 2. drop %config here, those really aren't user-editable config files %config(noreplace) %{_sysconfdir}/dbus-1/system.d/org.kde.kcontrol.kcmsddm.conf Updated: Spec URL: http://mbriza.fedorapeople.org/sddm/sddm-kcm.spec SRPM URL: http://mbriza.fedorapeople.org/sddm/sddm-kcm-0.0.0-0.1.20131015gitafdda33c.fc19.src.rpm Notes: 1. There is no official release, just git. I'm not sure if this versioning will be fine - I just suppose sddm-kcm will use the same versioning scheme as sddm does. 2. It doesn't list themes but other settings work. According to the guidelines, Version for completely unreleased packages should be 0, not 0.0.0. License: ok 1. Naming: mostly ok, please do reset to Version: 0 per comment #2 macros: ok 2. scriptlets: mostly ok, there's an extranous %post -p /sbin/ldconfig %postun -p /sbin/ldconfig which is not needed, please remove. The reset is clean and simple, APPROVED. please address items 1,2 prior to doing any official builds. New Package SCM Request ======================= Package Name: sddm-kcm Short Description: SDDM KDE configuration module Owners: mbriza than rdieter kkofler ltinkl jgrulich dvratil Branches: f18 f19 f20 InitialCC: Git done (by process-git-requests). sddm-kcm-0-0.1.20131114gitafdda33c.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/sddm-kcm-0-0.1.20131114gitafdda33c.fc20 sddm-kcm-0-0.1.20131114gitafdda33c.fc20 has been pushed to the Fedora 20 testing repository. sddm-kcm-0-0.1.20131114gitafdda33c.fc20 has been pushed to the Fedora 20 stable repository. |