Bug 1019455
| Summary: | Global proxy configuration prevents feed-less repos | ||
|---|---|---|---|
| Product: | [Retired] Pulp | Reporter: | Justin Sherrill <jsherril> |
| Component: | API/integration | Assignee: | Jay Dobies <jason.dobies> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Preethi Thomas <pthomas> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | urgent | ||
| Version: | Master | CC: | mhrivnak, pthomas, skarmark |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | 2.3.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-09 14:30:44 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
As a part of this bug, we need to check whether the same problem exists in iso_importer as well. https://github.com/pulp/pulp/pull/666 The fix was in the standard config validation in the platform, so it will apply across all plugins that use it. The ISO importer actually doesn't support a default config file at all, so this bug/fix is irrelevant. Thats an excellent point Sayli and Jay, as i worried at first because katello wasn't configuring a global iso configuration, but now i know that pulp doesn't support it, i will file a bug :) via IRC just now: <mhrivnak> mmccune_mtg, jsherrill how urgently do you want this in a new build? https://bugzilla.redhat.com/show_bug.cgi?id=1019455 <mmccune_mtg> mhrivnak: by next week (tues) would be goo build: 2.3.0-0.23.beta [root@qe-blade-03 ~]# rpm -qa |grep pulp-server
pulp-server-2.3.0-0.23.beta.fc19.noarch
[root@qe-blade-03 ~]#
[root@qe-blade-03 ~]# cat /etc/pulp/server/plugins.conf.d/yum_importer.json
{
"num_threads" : 4,
"proxy_host" : "http://pulp-proxy.usersys.redhat.com",
"proxy_port" : 3128,
"proxy_username": null,
"proxy_password": null
}
[root@qe-blade-03 ~]# pulp-admin rpm repo create --repo-id nofeed
Successfully created repository [nofeed]
[root@qe-blade-03 ~]#
[root@qe-blade-03 ~]# pulp-admin iso repo create --repo-id test-iso Successfully created repository [test-iso] [root@qe-blade-03 ~]# pulp-admin puppet repo create --repo-id test-puppet Successfully created repository [test-puppet] Pulp 2.3 released. |
Description of problem: Currently if I define a global proxy config in /etc/pulp/server/plugins.conf.d/yum_importer.json and then try to create a repo without a feed url, pulp throws an error: Body: {"http_request_method": "POST", "exception": null, "error_message": "Configuration errors:\nThe configuration parameter <feed> is required when any of the following other parameters are defined: max_speed, max_downloads, proxy_password, proxy_port, proxy_host, proxy_username, retain_old_count, ssl_ca_cert, ssl_client_cert, ssl_client_key, validate", "_href": "/pulp/api/v2/repositories/", "http_status": 400, "args": ["Configuration errors:\nThe configuration parameter <feed> is required when any of the following other parameters are defined: max_speed, max_downloads, proxy_password, proxy_port, proxy_host, proxy_username, retain_old_count, ssl_ca_cert, ssl_client_cert, ssl_client_key, validate"], "traceback": null} Version-Release number of selected component (if applicable): 2.3 How reproducible: Always Steps to Reproduce: 1. Create a global proxy config /etc/pulp/server/plugins.conf.d/yum_importer.json { "num_threads" : 4, "proxy_host" : "http://quartet.rdu.redhat.com", "proxy_port" : 8888, "proxy_username": null, "proxy_password": null } 2. Restart httpd 3. Attempt to create a repo with no feed Actual results: Error Expected results: Repo creates fine. Additional info: Either the restriction needs to be relaxed for a global proxy config, or the restriction needs to be relaxed all together. I really don't see much benefit to having this restriction in place.