Bug 1019537

Summary:	Lab controller daemons do not log details of unhandled XML-RPC exceptions
Product:	[Retired] Beaker	Reporter:	Nick Coghlan <ncoghlan>
Component:	lab controller	Assignee:	Dan Callaghan <dcallagh>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.14	CC:	aigao, asaha, dcallagh, llim, qwan, rmancy, xjia
Target Milestone:	0.15.3
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1003709	Environment:
Last Closed:	2014-02-03 04:52:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1003709
Bug Blocks:

Description Nick Coghlan 2013-10-16 02:38:40 UTC

+++ This bug was initially created as a clone of Bug #1003709 +++

Description of problem:
The exception details are not logged if an XML-RPC call throws an exception in one of the Beaker lab controller daemons.

Version-Release number of selected component (if applicable):
0.14

Steps to Reproduce (for example):
1. Break beaker-proxy's ability to run 'sudo beaker-clear-netboot', for example by commenting out the lines in /etc/sudoers.d/beaker_proxy_clear_netboot
2. Make a call to beaker-proxy to clear netboot for some system, using XML-RPC:

>>> import xmlrpclib
>>> s = xmlrpclib.ServerProxy('http://localhost:8000/RPC2')
>>> s.clear_netboot('testsystem.example.com')

Actual results:
Clients receive an XML-RPC fault, which is correct, but on the beaker-proxy side nothing useful is logged indicating that the request failed, or why.

Expected results:
Log messages in /var/log/beaker/proxy.log showing that the request failed, and why (including, for the particular example, the error message from sudo or beaker-clear-netboot if there was one).

Additional info:
This was originally reported as part of bug 1003709, but the resolution there only addressed the HTTP side of the problem. This bug now covers the XML-RPC side.

Comment 1 Dan Callaghan 2014-01-21 00:56:20 UTC

On Gerrit:

http://gerrit.beaker-project.org/2703

Comment 5 Nick Coghlan 2014-02-03 04:52:24 UTC

This change is included in the Beaker 0.15.3 maintenance release:

http://beaker-project.org/docs/whats-new/release-0.15.html#beaker-0-15-3