Bug 1019875

Summary: Title of element does not reflect an element type
Product: [Retired] JBoss BPMS Platform 6 Reporter: Sona Mala <smala>
Component: jBPM DesignerAssignee: Tihomir Surdilovic <tsurdilo>
Status: CLOSED CURRENTRELEASE QA Contact: Sona Mala <smala>
Severity: medium Docs Contact:
Priority: high    
Version: 6.0.0CC: kverlaen, mbaluch
Target Milestone: ER5Keywords: TestBlocker
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:08:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1019885    
Attachments:
Description Flags
Title for User Task - screenshot
none
Title for None Task - screenshot
none
Title for Start Event- screenshot
none
Title for Error Start Event- screenshot
none
Title for Error End Event- screenshot
none
Title for End Event- screenshot none

Description Sona Mala 2013-10-16 14:37:57 UTC
Description of problem:
If you change type of task from None task to User task then the title is is still same.

User is able to recognize Start Event and Message Start Event but not Message Start Event and Message End Event.

See attached screenshots.

Expected results:
Use an unique identifier for each type of element.

Comment 1 Sona Mala 2013-10-16 14:38:29 UTC
Created attachment 812966 [details]
Title for User Task - screenshot

Comment 2 Sona Mala 2013-10-16 14:38:52 UTC
Created attachment 812968 [details]
Title for None Task - screenshot

Comment 3 Sona Mala 2013-10-16 14:40:08 UTC
Created attachment 812969 [details]
Title for Start Event- screenshot

Comment 4 Sona Mala 2013-10-16 14:40:37 UTC
Created attachment 812970 [details]
Title for Error Start Event- screenshot

Comment 5 Sona Mala 2013-10-16 14:42:39 UTC
Created attachment 812983 [details]
Title for Error End Event- screenshot

Comment 6 Sona Mala 2013-10-16 14:43:10 UTC
Created attachment 812984 [details]
Title for End Event- screenshot

Comment 8 Tihomir Surdilovic 2013-10-21 20:24:09 UTC
There was no easy way to fix this issue due to the addition of type-specific tasks in the stencil set. The titles are not dynamically reset on node creation so they do not change when the type changes (morphing). 

I have removed titles from svg nodes on the canvas (nodes + edges/sequence flows). I think this is the best thing to do to not confuse users at this time.

As far as iterating through the nodes on canvas for your tests. Using the title is probably a bad idea anyways. Designer exposes you with a JS api you can use to easily iterate over these..for example lets say you have designer loaded on the browser (designer-standalone lets say), you can do:

window.frames[2].ORYX.EDITOR._canvas.getChildren() to get a list of all children of the canvas (all nodes). Note that you might have to replace the "2" with another number depending if you are testing designer-standalone or kie-wb for example. Now you can iterate if you want with JS:


window.frames[2].ORYX.EDITOR._canvas.getChildren().each(function(child) {

alert(child._stencil.id();

});

the alert will give you the stencil set title of the node which is the best way of determining its type, for example it will give you:

- http://b3mn.org/stencilset/bpmn2.0#Task for tasks
- http://b3mn.org/stencilset/bpmn2.0#ParallelGateway for gateways etc

if you want a specific task type you can do for example:

child.properties["oryx-tasktype"]

which will give you for user task "User" as result..there are lots more things you can do with the Designer JS api but I hope this helps for now.

Comment 9 Marek Baluch 2013-11-27 21:37:55 UTC
Verified on ER5.