Bug 102022
| Summary: | defaults.el buglets | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Raw Hide | Reporter: | Ville Skyttä <scop> | ||||
| Component: | xemacs | Assignee: | Jens Petersen <petersen> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Jay Turner <jturner> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 1.0 | CC: | srevivo | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2003-09-12 15:36:09 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Ville Skyttä
2003-08-08 22:33:36 UTC
Created attachment 93540 [details]
Fix for newline-related defcustom defaults
Actually I noticed that next-line-add-newlines defaults to nil in XEmacs is that is probably not necessary. I have mixed feelings about the require-final-newline setting (perhaps 'ask is a friendlier default, though it becomes a little more verbose). Agreed that these shouldn't have been in "default.el", thanks for spotting that. I guess setq-default is ok, but isn't setq sufficient? I just wonder if setq-default might not confuse users more than setq. "I setq'd require-final-newline in my init file and the value is still..."? Well not such a big deal either way. My personal feeling about require-final-newline is that it is good have on by default. If people haven't complained, why change it? :) I'm sure that people would be annoyed by 'ask. Setting next-line-add-newlines to nil is redundant, you're right. It also defaults to nil in XEmacs 21.5 and the documentation strongly suggests that it won't change (see C-h v next-line-add-newlines :) Regarding the setq vs setq-default issue, I believe you and I have the same goal wrt. site-start.el: to set a good system default and to allow users to override it in via customize in custom.el or manually in init.el. I don't see any difference whether setq or setq-default is used in site-start.el, I can still customize the setting as a user just as I like. But IMO setq-default is exactly what we want to do: to set the default value (setq-default) instead of unconditionally setting it to a specified value at some point of time (setq). I'm not 100% confident that I understand the semantics of setq-default though, but it seems The Right Thing To Do to me. While I'm at it, new Sumo packages are out... and they contain at least one annoying bug in rpm-spec-mode for us Epoch: 0 enthusiasts, fix at http://cvs.xemacs.org/viewcvs.cgi/XEmacs/packages/xemacs-packages/prog-modes/rpm-spec-mode.el.diff?r1=1.15&r2=1.16&diff_format=u FWIW, I tried out setting require-final-newline to 'ask, but it drives me crazy in about 2 minute. I suspect there are lots of users around that feel the same, especially beginners. Please consider setq-default'ing it to t as it has been a long time default... FYI: if you're planning an update soon, 21.4.14 is out... require-final-newline will default to t in 21.4.14-1. Thanks! |