Bug 1020299

The same problem is in Maven.
We're working on the fix now.

(In reply to Mikolaj Izdebski from comment #1)
> The same problem is in Maven.
> We're working on the fix now.

Hi Mikolaj,

Is there any update on this? I've kinda just left it to the side since I'm assuming it's all one problem.

Thanks.

Sorry, I forgot to add a comment here.  I've already solved this and fixed locally on my system.  In this particular case there were a few missing symlinks to different apache-commons libraries.

The generic problem is that M2E spec file has a list of symlinks to Maven dependencies which you need to synchronize manually each time Maven dependency changes.  This is tedious and error prone.

Gerard, if you don't mind I'll take care of this bug and update M2E spec file to automatically symlink JARs.

(In reply to Mikolaj Izdebski from comment #3)
> Sorry, I forgot to add a comment here.  I've already solved this and fixed
> locally on my system.  In this particular case there were a few missing
> symlinks to different apache-commons libraries.
> 
> The generic problem is that M2E spec file has a list of symlinks to Maven
> dependencies which you need to synchronize manually each time Maven
> dependency changes.  This is tedious and error prone.
> 
> Gerard, if you don't mind I'll take care of this bug and update M2E spec
> file to automatically symlink JARs.

I don't mind at all, in fact I'd be very grateful! Thanks! :)

Fixed in eclipse-m2e-core-1.4.0-9

eclipse-m2e-core-1.4.0-9.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/eclipse-m2e-core-1.4.0-9.fc20

(In reply to Mikolaj Izdebski from comment #5)
> Fixed in eclipse-m2e-core-1.4.0-9

Hi Mikolaj,

Thanks for helping out on this. I've given that version a quick try, and I can't get the "New Maven Project" dialog to open at all:

>The selected wizard could not be started.
>Plug-in org.eclipse.m2e.core.ui was unable to load class >org.eclipse.m2e.core.ui.internal.wizards.MavenProjectWizard.
>An error occurred while automatically activating bundle org.eclipse.m2e.core.ui >(596).

Here's the traceback: http://paste.fedoraproject.org/65426/87024581/

It seems like that workaround for adding cglib is still necessary. I'm not able to build the latest version with xmvn-subst in my local mock (I may have some old packages there or something), so I've started a scratch on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6351177

I likely won't get a chance to try that until tomorrow after work, so in the meantime: are there any other bad side-effects that you can think of to having that workaround re-added?

Hopefully I'll be able to make some attempts at m2e-core 1.5.0 milestone versions soon: I'm hoping it will bring some sanity back to this package. I've packaged some of the new dependencies, but it seems that there's some stuff in it that depends on the newer version of guava that we don't have yet (bug #1023832).

Thanks,
Gerard.

Of course that would have been much better as an F20 scratch build. Sigh.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6351185

I've updated the bodhi update to re-add the cglib/aopalliance workaround, which fixed the problem for me that I mentioned in comment #7.

(In reply to Gerard Ryan from comment #7)
> Thanks for helping out on this. I've given that version a quick try, and I
> can't get the "New Maven Project" dialog to open at all:
> 
> >The selected wizard could not be started.
> >Plug-in org.eclipse.m2e.core.ui was unable to load class >org.eclipse.m2e.core.ui.internal.wizards.MavenProjectWizard.
> >An error occurred while automatically activating bundle org.eclipse.m2e.core.ui >(596).
> 
> Here's the traceback: http://paste.fedoraproject.org/65426/87024581/
> 
> It seems like that workaround for adding cglib is still necessary.

The problem appears to be caused by missing dependency exclusion on Guice and incorrect dependency scope on Sisu Plexus.  The original dependency on Sonatype Sisu has Guice exclusion, which is lost when Sonatype Sisu dependency is replaced with Eclipse Sisu.  Similarly scope "provided" is changed to default "compile".  Readding exclusion and resetting scope to "provided" fixes the problem you described.

> I'm not
> able to build the latest version with xmvn-subst in my local mock (I may
> have some old packages there or something), so I've started a scratch on
> koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6351177

You probably had too old Guice and/or Sisu.  I've tightened BuildRequires prevent that.

> I likely won't get a chance to try that until tomorrow after work, so in the
> meantime: are there any other bad side-effects that you can think of to
> having that workaround re-added?

Adding extra dependencies to Maven runtime will sooner or later lead to conflicts between different versions of the same library.

An example: Maven PMD Plugin requires CGlib.  If you try to run PMD plugin from M2E then two different versions of CGlib will be added to plugin class realm (one as dep of the plugin and the second one as dep of maven-runtime), which is likely to cause strange problems.


Gerard, I've pushed the fix and launched build.  If it works for you then I'll respin the update.

(In reply to Mikolaj Izdebski from comment #10)
> Gerard, I've pushed the fix and launched build.  If it works for you then
> I'll respin the update.

Works for me. Thanks for the help, and the explanation of the exclusions (I knew there must have been a good reason!). I'll leave it to you so to change the update to this version...I'll be away for the next week.

Thanks again,
Gerard.

Update for Fedora 20 is requested for testing.

eclipse-m2e-core-1.4.0-11.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

I believe that this bug is fixed in eclipse-m2e-core-1.4.0-11,
which is available in updates for Fedora 20, so I am closing this bug now.

The build containing the fix can be found at Koji:
http://koji.fedoraproject.org/koji/buildinfo?buildID=488221