Bug 1021084

Summary: UI - content definition filter - unable to remove extra Puppet module parameters
Product: Red Hat Satellite Reporter: Dominic Cleal <dcleal>
Component: WebUIAssignee: David Davis <daviddavis>
Status: CLOSED WONTFIX QA Contact: Katello QA List <katello-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0.2CC: mmccune
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-11 16:43:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Dominic Cleal 2013-10-19 08:38:41 UTC
Description of problem:
When constructing a content view filter for Puppet modules, you're prompted to enter the module name and given a "+ Add" link to the right.  Each time you click it, a new "parameter" appears which enables filtering by author and version.  There's no obvious way to get rid of these new filters.

Version-Release number of selected component (if applicable):
katello-1.4.6-40.el6sat.noarch
katello-all-1.4.6-40.el6sat.noarch
katello-candlepin-cert-key-pair-1.0-1.noarch
katello-certs-tools-1.4.4-1.el6sat.noarch
katello-cli-1.4.3-24.el6sat.noarch
katello-cli-common-1.4.3-24.el6sat.noarch
katello-common-1.4.6-40.el6sat.noarch
katello-configure-1.4.7-6.el6sat.noarch
katello-configure-foreman-1.4.7-6.el6sat.noarch
katello-foreman-all-1.4.6-40.el6sat.noarch
katello-glue-candlepin-1.4.6-40.el6sat.noarch
katello-glue-elasticsearch-1.4.6-40.el6sat.noarch
katello-glue-pulp-1.4.6-40.el6sat.noarch
katello-qpid-broker-key-pair-1.0-1.noarch
katello-qpid-client-key-pair-1.0-1.noarch
katello-selinux-1.4.4-4.el6sat.noarch
pulp-katello-plugins-0.2-1.el6sat.noarch
ruby193-rubygem-foreman-katello-engine-0.0.17-6.el6sat.noarch
ruby193-rubygem-katello_api-0.0.3-4.el6sat.noarch
ruby193-rubygem-katello-foreman-engine-0.0.12-3.el6sat.noarch
signo-katello-0.0.23-2.el6sat.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create a content view definition including a puppet module repo
2. Create a filter called "test", add the puppet module repo
3. Create a puppet module rule
4. Enter "stdlib" in the module name box
5. Click "+ Add" three times
6. Return to the filter view, click "Filter: test" at the top
7. Click on the rule again
8. Try to remove the two additional parameters

Actual results:
5. Allows you to create and save multiple blank parameters
6. Rule summary says: "Include Puppet Modules: stdlib, stdlib, stdlib"
7. Module name is missing from the top box, three blank parameters still listed
8. No remove button?

Expected results:
5. I expect that "+ Add" adds the module rule itself, not additional parameters.  Instead, perhaps always show a blank parameter row, that when filled in is added to the saved list.
6. "Include Puppet Module: stdlib"
7. Module name is shown, only one stored parameter shown
8. A remove link somewhere

Comment 2 Dominic Cleal 2013-10-19 09:05:18 UTC
Ah, I see it now.  The tickbox next to "Author" lets you select it for removal - I thought that was enabling the author filtering.

Will leave this open as it could do with some padding IMO, plus the related module name disappearing issue above.

Comment 4 Bryan Kearney 2014-03-11 16:43:28 UTC
Closing old bugs which are not relevant based on new UI and CLI