Bug 1021160

1. This package should be named in python-doge and also a parallel installable python3 subpackage named python3-doge.

2. I can't understand "wow very terminal doge", can you change it to something better?

3. BuildRequires:  python2-devel

missing

BuildRequires:  python-setuptools

4. Remove rm -rf %{buildroot}

5. %{__python} --> %{__python2}

%{python_sitelib} --> %{python2_sitelib}

wow such review, many feedback

upstream description is "wow very terminal doge" https://github.com/thiderman/doge

(In reply to Christopher Meng from comment #1)
> 1. This package should be named in python-doge and also a parallel
> installable python3 subpackage named python3-doge.

This isn't a Python library; it's a program that happens to be a Python module. It doesn't make sense to have a subpackage that runs on Python 3. (What would we call the separate Python 3 binary? There are no packaging policies for this.)

Examples of packages that provide Python modules but are not called python-$module, because they are standalone programs and not libraries:

- anaconda
- yum
- ansible
- gnome-tweak-tool

> 2. I can't understand "wow very terminal doge", can you change it to
> something better?

As Ryan mentioned, this is the upstream summary description, and is directly relevant to the package contents.

> 3. BuildRequires:  python2-devel
> 
> missing
> 
> BuildRequires:  python-setuptools

setup.py doesn't use setuptools, so this BuildRequires isn't needed at all.

For further evidence, see this Koji scratch build:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=6080518

> 4. Remove rm -rf %{buildroot}
> 
> 5. %{__python} --> %{__python2}
> 
> %{python_sitelib} --> %{python2_sitelib}

4 and 5 fixed in 0.6.1-2:

Spec URL: http://ianweller.fedorapeople.org/SRPMS/doge/0.6.1-2/doge.spec
SRPM URL: http://ianweller.fedorapeople.org/SRPMS/doge/0.6.1-2/doge-0.6.1-2.fc19.src.rpm

Like I've said:

doge.noarch: W: summary-not-capitalized C wow very terminal doge
doge.noarch: W: name-repeated-in-summary C doge

Upstream use this summary doesn't mean that it's readable and understandable. Please consider a change.

Spec URL: http://ianweller.fedorapeople.org/SRPMS/doge/0.7.1-1/doge.spec
SRPM URL: http://ianweller.fedorapeople.org/SRPMS/doge/0.7.1-1/doge-0.7.1-1.fc19.src.rpm

doge.noarch: W: summary-not-capitalized C wow very terminal doge

Only this issue, please reply me with alternatives.(You don't need to build again, no need).

The correct URL is https://pypi.python.org/pypi/doge/

A valid summary would be
 A simple motd script based on the slightly retarded but very funny doge meme

(In reply to Susi Lehtola from comment #7)
> The correct URL is https://pypi.python.org/pypi/doge/

That is not the location of the website for the upstream project. The URL I gave is the correct one. The PyPI URL is a package index URL, which is unhelpful if a user wants to report a bug upstream.

(In reply to Susi Lehtola from comment #7)
> A valid summary would be
>  A simple motd script based on the slightly retarded but very funny doge meme

Agree. Please change to something like this one.

What about the summary solution? Ian, please don't think that we are waiting futile change, changing to a clearer summary will help a lot for other users.

1.0.0 is available now.

Spec URL: http://ianweller.fedorapeople.org/SRPMS/doge/2.2.0-1/doge.spec
SRPM URL: http://ianweller.fedorapeople.org/SRPMS/doge/2.2.0-1/doge-2.2.0-1.fc19.src.rpm

Hmm...Crazy upstream...

------------------
PACKAGE APPROVED.

New Package SCM Request
=======================
Package Name: doge
Short Description: MOTD script based on the doge meme
Owners: ianweller
Branches: f19 f20 el6
InitialCC:

Git done (by process-git-requests).

doge-2.2.0-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/doge-2.2.0-1.fc19

doge-2.2.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/doge-2.2.0-1.fc20

doge-2.2.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/doge-2.2.0-2.el6

doge-2.2.0-1.fc20 has been pushed to the Fedora 20 testing repository.

doge-2.2.0-1.fc20 has been pushed to the Fedora 20 stable repository.