| Summary: | Review Request: general-purpose-preprocessor - Customizable language-agnostic preprocessor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Component: | Package Review | Assignee: | Brendan Jones <brendan.jones.it> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | brendan.jones.it, i, notting, package-review |
| Target Milestone: | --- | Flags: | brendan.jones.it:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | general-purpose-preprocessor-2.24-3.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-11-07 03:31:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 1015701 | ||
|
Description
Zbigniew Jędrzejewski-Szmek
2013-10-20 02:35:57 UTC
Hmm.... Do we really need this ancient tool? ;) (In reply to Christopher Meng from comment #1) > Do we really need this ancient tool? ;) I asked myself the same question. But the package is tiny, trivial to package, and Debian has it. I tried to reimplement the necessary functionality in perl, but it's not as trivial as packaging gpp. I guess that if users don't pop up, the package can be retired in the next release or something like that. Oops, name 'gpp' is already taken. Renaming to general-purpose-preprocessor, because gnome-printer-panel only uses the package name 'gpp', but doesn't install anything with this name. Spec URL: http://in.waw.pl/~zbyszek/fedora/general-purpose-preprocessor.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/general-purpose-preprocessor-2.24-3.fc19.src.rpm I'll take this on. Rpmlint output is OK except this: general-purpose-preprocessor-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package general-purpose-preprocessor. general-purpose-preprocessor-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gpp-2.24/src/gpp.c Fix the first and notify the author of the second at your discretion. No other issues - this package is APPROVED Review: * Accompanying license is good and matches source headers * Package doesn't create any directories it doesn't own * SPEC file is according to standard and in legible US format * Latest version is packaged * Requires are sane * Package functions as described (In reply to Brendan Jones from comment #5) > Rpmlint output is OK except this: > > general-purpose-preprocessor-debuginfo.x86_64: E: description-line-too-long > C This package provides debug information for package > general-purpose-preprocessor. The description is generated automatically. It's too long because of the long package name... I think it's a known issue. > general-purpose-preprocessor-debuginfo.x86_64: E: incorrect-fsf-address > /usr/src/debug/gpp-2.24/src/gpp.c > > Fix the first and notify the author of the second at your discretion. Done. I took the opportunity to notify upstream maintainer about the package. > No other issues - this package is APPROVED Thank you for the review! New Package SCM Request ======================= Package Name: general-purpose-preprocessor Short Description: A general-purpose preprocessor with customizable syntax Owners: zbyszek Branches: f19 f20 InitialCC: Git done (by process-git-requests). general-purpose-preprocessor-2.24-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/general-purpose-preprocessor-2.24-3.fc20 general-purpose-preprocessor-2.24-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/general-purpose-preprocessor-2.24-3.fc19 Package general-purpose-preprocessor-2.24-3.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing general-purpose-preprocessor-2.24-3.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-20024/general-purpose-preprocessor-2.24-3.fc20 then log in and leave karma (feedback). general-purpose-preprocessor-2.24-3.fc19 has been pushed to the Fedora 19 stable repository. general-purpose-preprocessor-2.24-3.fc20 has been pushed to the Fedora 20 stable repository. |