Bug 1021476

Summary: Add serial property supported for IDE device
Product: Red Hat Enterprise Linux 6 Reporter: Sibiao Luo <sluo>
Component: qemu-kvmAssignee: Virtualization Maintenance <virt-maint>
Status: CLOSED DEFERRED QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: high    
Version: 6.5CC: acathrow, bsarathy, chayang, juzhang, michen, mkenneth, pbonzini, qzhang, virt-maint, xfu
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-10-24 23:21:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Sibiao Luo 2013-10-21 11:29:03 UTC 
Description of problem:
as subject.

Version-Release number of selected component (if applicable):
host info:
# uname -r && rpm -q qemu-kvm
2.6.32-424.el6.x86_64
qemu-kvm-0.12.1.2-2.414.el6.x86_64
guest info:
2.6.32-424.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1.check the qemu-kvm man help for ide-drive.
# /usr/libexec/qemu-kvm -device ide-drive,?
ide-drive.unit=uint32
ide-drive.drive=drive
ide-drive.logical_block_size=blocksize
ide-drive.physical_block_size=blocksize
ide-drive.min_io_size=uint16
ide-drive.opt_io_size=uint32
ide-drive.bootindex=int32
ide-drive.discard_granularity=uint32
ide-drive.ver=string
ide-drive.wwn=hex64
2.boot guest with serial property for ide-drive device.
e.g:...-drive file=/home/my-data-disk.raw,if=none,id=drive-data-disk,format=raw,aio=native -device ide-drive,drive=drive-data-disk,id=data-disk,serial=sluo-disk
qemu-kvm: -device ide-drive,drive=drive-data-disk,id=data-disk,serial=sluo-disk: Property 'ide-drive.serial' not found
3.boot guest with serial property for ide-drive drive.
e.g:...-drive file=/home/my-data-disk.raw,if=none,id=drive-data-disk,format=raw,aio=native,serial=sluo-disk -device ide-drive,drive=drive-data-disk,id=data-disk
# scsi_id --whitelist /dev/sda
1ATA     QEMU HARDDISK                           sluo-disk           
guest ]# scsi_id --whitelist /dev/sdb

Actual results:
after step 2, fail to boot guest with serial property for ide-drive device.
after step 3, it work well with serial property for ide-drive drive.

Expected results:
Add serial property supported for IDE device.
# /usr/libexec/qemu-kvm -device ide-drive,?
...
ide-drive.wwn=hex64
ide-drive.serial=string
...

Additional info:
Comment 1 Sibiao Luo 2013-10-21 11:30:37 UTC 
Also tried rhel7 host that did not hit such issue, it work well for ide device.
Comment 3 Paolo Bonzini 2013-10-24 23:21:08 UTC 
Libvirt is able anyway to specify a serial number for IDE devices, so there is no benefit from adding this property.
Comment 4 Sibiao Luo 2013-11-08 08:06:06 UTC 
(In reply to Paolo Bonzini from comment #3)
> Libvirt is able anyway to specify a serial number for IDE devices, so there
> is no benefit from adding this property.
You are correct, but we have such case to cover it, all the ide/virtio-blk/virtio-scsi has two methods to specify the serial number for its drive or device, and rhel7 has no such issue.
I do suggest that we'd better to fix it work in rhel6.6, or we need to make a note to hight it in our test case/plan. Any idea about it ? 

Best Regards,
sluo
Comment 5 Paolo Bonzini 2013-11-08 09:48:22 UTC 
The Virtualization Administration Guide does not list "serial" among the supported properties of ide-drive, so the test plan is wrong.