Bug 1021501

Summary:	Uploading an invalid puppet module results in "undefined method `each' for nil:NilClass"
Product:	Red Hat Satellite	Reporter:	David Davis <daviddavis>
Component:	Hammer	Assignee:	David Davis <daviddavis>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Og Maciel <omaciel>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.0.2	CC:	jmontleo, mmccune, omaciel, sghai, walden
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-24 17:10:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Davis 2013-10-21 12:22:36 UTC

Description of problem:

Per https://bugzilla.redhat.com/show_bug.cgi?id=1013656#c6, when you upload an invalid puppet module you get extra dialogue and an error:

$ k repo content_upload --repo=p --filepath=puppetlabs-ntp-2.0.1.tar.gz --content_type=puppet --product=PForge
Invalid puppet module 'puppetlabs-ntp-2.0.1.tar.gz'. Please make sure the file is valid and is named author-name-version.tar.gz (eg: puppetlabs-ntp-2.0.1.tar.gz).
Importing content into repositoryundefined method `each' for nil:NilClass


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Create a puppet repo
2. Upload an invalid puppet module

Actual results:

See "Importing content into repositoryundefined method `each' for nil:NilClass"

Expected results:

No "Importing content into repositoryundefined method `each' for nil:NilClass"

Comment 2 David Davis 2013-10-21 17:26:36 UTC

https://github.com/Katello/katello-cli/pull/116

katello-cli 33614c2ab3472642fc1369145351d1bd7d542b0a

1021501: Checking uploads before importing into repo

Comment 6 Og Maciel 2013-10-24 02:35:34 UTC

Verified:

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.8.25-1.el6sam.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.8.25-1.el6sam.noarch
* candlepin-tomcat6-0.8.25-1.el6sam.noarch
* elasticsearch-0.19.9-8.el6sat.noarch
* foreman-1.3.0-20.el6sat.noarch
* foreman-compute-1.3.0-20.el6sat.noarch
* foreman-libvirt-1.3.0-20.el6sat.noarch
* foreman-postgresql-1.3.0-20.el6sat.noarch
* foreman-proxy-1.3.0-3.el6sat.noarch
* katello-1.4.6-47.el6sat.noarch
* katello-all-1.4.6-47.el6sat.noarch
* katello-candlepin-cert-key-pair-1.0-1.noarch
* katello-certs-tools-1.4.4-1.el6sat.noarch
* katello-cli-1.4.3-27.el6sat.noarch
* katello-cli-common-1.4.3-27.el6sat.noarch
* katello-common-1.4.6-47.el6sat.noarch
* katello-configure-1.4.7-7.el6sat.noarch
* katello-configure-foreman-1.4.7-7.el6sat.noarch
* katello-foreman-all-1.4.6-47.el6sat.noarch
* katello-glue-candlepin-1.4.6-47.el6sat.noarch
* katello-glue-elasticsearch-1.4.6-47.el6sat.noarch
* katello-glue-pulp-1.4.6-47.el6sat.noarch
* katello-qpid-broker-key-pair-1.0-1.noarch
* katello-qpid-client-key-pair-1.0-1.noarch
* katello-selinux-1.4.4-4.el6sat.noarch
* openldap-2.4.23-31.el6.x86_64
* pulp-katello-plugins-0.2-1.el6sat.noarch
* pulp-nodes-common-2.3.0-0.22.beta.el6sat.noarch
* pulp-nodes-parent-2.3.0-0.22.beta.el6sat.noarch
* pulp-puppet-plugins-2.3.0-0.22.beta.el6sat.noarch
* pulp-rpm-plugins-2.3.0-0.22.beta.el6sat.noarch
* pulp-selinux-2.3.0-0.22.beta.el6sat.noarch
* pulp-server-2.3.0-0.22.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-ldap_fluff-0.2.2-2.el6sat.noarch
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.0.7-1.el6sat.noarch
* signo-0.0.23-2.el6sat.noarch
* signo-katello-0.0.23-2.el6sat.noarch

Comment 9 Bryan Kearney 2014-04-24 17:10:17 UTC

This was verified and delivered with MDP2. Closing it out.

Comment 10 Bryan Kearney 2014-04-24 17:11:35 UTC

This was delivered and verified with MDP2. Closing the bug.