Bug 1021606

Rafael Benevides <benevides> made a comment on jira RESTEASY-971

Resteasy 2.3.7 is used on EAP 6.2.0.Beta, that's why the priority was set to Critical

The versions in the resteasy bom should probably be changed to use the -redhat version for all artifacts.

Just to clarify previous comment, we probably want to trim the resteasy bom down to just the supported artifacts to make sure that we don't set a -redhat version for an artifact that is not shipped and supported with the maven repo zip.

The other issue is that abdera-atom-provider is not present on MavenCentral too: http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22org.jboss.resteasy%22%20AND%20a%3A%22abdera-atom-provider%22

We have two issues with this BOM:

1 - http://maven.repository.redhat.com/techpreview/eap6/6.2.0.Beta/maven-repository/org/jboss/resteasy/resteasy-bom/2.3.7.Final-redhat-2/resteasy-bom-2.3.7.Final-redhat-2.pom REferences non -redhat-x releases

2 - It references an non MavenCentral dependency:abdera-atom-provider 

So I'm increasing the Severity to High.

abdera-atom-provider is not supported by EAP/WildFly.

Here are the providers supported by EAP/WildFly:

<modules>
    <module>jaxb</module>
    <module>jettison</module>
    <module>fastinfoset</module>
    <module>jackson</module>
    <module>resteasy-atom</module>
    <module>multipart</module>
    <module>yaml</module>
    <module>resteasy-hibernatevalidator-provider</module>
</modules>

I didn't notice 'resteasy-bom' module is used by project jboss-eap-boms.

Paul, do we have the requirement to support this project from EAP side? If so, from future I'll provide a managed 'resteasy-bom' module.

Looks like there are actually two resteasy boms.
org.jboss.bom.eap:jboss-javaee-6.0-with-resteasy
depends on 
org.jboss.resteasy:resteasy-bom

I'm not really crazy about nested BOMs like this so it might be better to just put the correct managed dependencies directly into org.jboss.bom.eap:jboss-javaee-6.0-with-resteasy.

The other option is to remove unsupported stuff from org.jboss.resteasy:resteasy-bom as Weinan suggested.

There is only one quickstart which currently uses jboss-javaee-6.0-with-resteasy (jax-rs-client) so it probably makes sense to limit this bom to only resteasy jars which are part of the supported eap 6 api (i.e. non-private modules in eap).

(In reply to Paul Gier from comment #8)
> Looks like there are actually two resteasy boms.
> org.jboss.bom.eap:jboss-javaee-6.0-with-resteasy
> depends on 
> org.jboss.resteasy:resteasy-bom
> 

Thanks for catching this Paul. 'org.jboss.bom.eap:jboss-javaee-6.0-with-resteasy' shouldn't import 'org.jboss.resteasy:resteasy-bom', because 'org.jboss.resteasy:resteasy-bom' is for upstream and it contains all the components of RESTEasy.

I'll help to create a PR to 'org.jboss.bom.eap:jboss-javaee-6.0-with-resteasy' and just put the resteasy components available in EAP modules.

First commit: https://github.com/liweinan/jboss-eap-boms/commit/fb1dca70eaaa1abcf65321b6be67f32e2afa1e41

Hi Rafael, above are the resteasy components that we have in EAP6. Do you have any comments on it? If it's fine I'll go on adding the dependent artifacts of these components into pom.

Hi Weinan Li,

If all of them can be resolved in EAP distro, than it's fine for me :)

Thanks for clarification Rafael :-) I'll work on the dependencies, after finished them all I'll submit the PR.

Hi Rafael, could you please tell me which repository I should use to test the BOM? 

Currently I'm running 'mvn -U org.jboss.maven.plugins:maven-qstools-plugin:1.2.4.Final:bom-check' in my local environment and it failed:

[ERROR]     Non-resolvable import POM: Could not find artifact org.jboss.spec:jboss-javaee-6.0:pom:3.0.2.Final-redhat-5 in central (http://repo.maven.apache.org/maven2) @ line 43, column 25 -> [Help 2]

Hi Weinan,
You need to add http://maven.repository.redhat.com/earlyaccess/all
and http://maven.repository.redhat.com/techpreview/all/ to your settings.xml

Weinan, you can also test with the latest build of the maven repo zip in jenkins:
https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jboss-eap-6.2.x-maven-repository/

Thanks Paul & Rafael, I will go on testings with your information.

Hi Rafael, I've met the following problem:

[ERROR] Failed to execute goal org.jboss.maven.plugins:maven-qstools-plugin:1.2.4.Final:bom-check (default-cli) on project jboss-javaee-6.0-with-resteasy: Execution default-cli of goal org.jboss.maven.plugins:maven-qstools-plugin:1.2.4.Final:bom-check failed: Could not create object from user view: InvocationTargetException: Could not create new service instance: org/sonatype/aether/resolution/DependencyResolutionException: org.sonatype.aether.resolution.DependencyResolutionException -> [Help 1]

Could you please tell me how to fix this? Here is the version of maven I'm using:

mini:jboss-javaee-6.0-with-resteasy weinanli$ mvn -version
Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 23:22:22+0800)
Maven home: /usr/local/bin/apache-maven-3.1.1
Java version: 1.6.0_65, vendor: Apple Inc.
Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
Default locale: en_US, platform encoding: MacRoman
OS name: "mac os x", version: "10.9", arch: "x86_64", family: "mac"

Hi Weinan, maven-qstools-plugins has problem on maven:3.1.X, see: https://github.com/jboss-developer/maven-qstools-plugin#checking-the-bom-dependencies

And also you need to test it by specifying the maven settings.xml by: -Dorg.apache.maven.user-settings=YOUR-MAVEN-SETTINGS.XML

FYI: https://issues.jboss.org/browse/JDF-539

Hi Lin, thanks for these useful info!

Rafael and I validated that the proposed fix is working.  
The PR is here: https://github.com/jboss-developer/jboss-eap-boms/pull/48

I also added the -with-tools bom to the jax-rs-client quickstart to manage the version of JUnit.  Previously, the resteasy bom was providing the junit version.
https://github.com/jboss-developer/jboss-eap-quickstarts/commit/d6e0e1f8d8b53625a66b85f8868dcba0e8074983

Created attachment 825428 [details]
test script

1. create temporary directory and change into
2. download test.sh and jboss-eap-6.2.0.CR1-maven-repository.zip
3. run sh ./test.sh

failed using procedure described in comment#23

regarding the test script on comment#23 I suggest using 'mvn -U org.jboss.maven.plugins:maven-qstools-plugin:bom-check' instead of 'mvn org.jboss.maven.plugins:maven-qstools-plugin:1.2.4.Final:bom-check' to always use the latest plugin version.

RESTEasy 2.3.8 in EAP 6.3 doesn't have this problem.

Verified jboss-javaee-6.0-with-resteasy-6.3.0.Beta2 is fixed in EAP 6.3.0.ER7.

Ron Sigal <ron.sigal> updated the status of jira RESTEASY-971 to Closed

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days