Bug 1021612

Summary: No error reported during CV publish if Puppet install distributor fails due to duplicate names
Product: Red Hat Satellite Reporter: Dominic Cleal <dcleal>
Component: Content ManagementAssignee: David Davis <daviddavis>
Status: CLOSED CURRENTRELEASE QA Contact: Corey Welton <cwelton>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.0.2CC: cwelton, jmontleo, mmccune, omaciel
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1022621 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1022621    
Bug Blocks:    

Description Dominic Cleal 2013-10-21 15:55:13 UTC
Description of problem:
When refreshing or promoting a content view that contains a Puppet repo and the publish (using the puppet_install_distributor) fails, no failure is reported.  Pulp does log the error, but this doesn't bubble up to the Katello CV process.

Failure should occur because there modules with the same conflicting name, but different order.  mhrivnak says the error should be present in the publish report too.

Version-Release number of selected component (if applicable):
createrepo-0.9.9-21.2.pulp.el6sat.noarch
katello-1.4.6-40.el6sat.noarch
katello-all-1.4.6-40.el6sat.noarch
katello-candlepin-cert-key-pair-1.0-1.noarch
katello-certs-tools-1.4.4-1.el6sat.noarch
katello-cli-1.4.3-24.el6sat.noarch
katello-cli-common-1.4.3-24.el6sat.noarch
katello-common-1.4.6-40.el6sat.noarch
katello-configure-1.4.7-6.el6sat.noarch
katello-configure-foreman-1.4.7-6.el6sat.noarch
katello-foreman-all-1.4.6-40.el6sat.noarch
katello-glue-candlepin-1.4.6-40.el6sat.noarch
katello-glue-elasticsearch-1.4.6-40.el6sat.noarch
katello-glue-pulp-1.4.6-40.el6sat.noarch
katello-qpid-broker-key-pair-1.0-1.noarch
katello-qpid-client-key-pair-1.0-1.noarch
katello-selinux-1.4.4-4.el6sat.noarch
m2crypto-0.21.1.pulp-8.el6sat.x86_64
mod_wsgi-3.4-1.pulp.el6sat.x86_64
pulp-katello-plugins-0.2-1.el6sat.noarch
pulp-nodes-common-2.3.0-0.22.beta.el6sat.noarch
pulp-nodes-parent-2.3.0-0.22.beta.el6sat.noarch
pulp-puppet-plugins-2.3.0-0.22.beta.el6sat.noarch
pulp-rpm-plugins-2.3.0-0.22.beta.el6sat.noarch
pulp-selinux-2.3.0-0.22.beta.el6sat.noarch
pulp-server-2.3.0-0.22.beta.el6sat.noarch
python-isodate-0.5.0-1.pulp.el6sat.noarch
python-oauth2-1.5.170-3.pulp.el6sat.noarch
python-pulp-bindings-2.3.0-0.22.beta.el6sat.noarch
python-pulp-common-2.3.0-0.22.beta.el6sat.noarch
python-pulp-puppet-common-2.3.0-0.22.beta.el6sat.noarch
python-pulp-rpm-common-2.3.0-0.22.beta.el6sat.noarch
python-rhsm-1.8.0-1.pulp.el6sat.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Sync Puppet forge to a repo
2. Create content view containing repo
3. Publish content view
4. Check notifications
5. grep "publish failed" /var/log/pulp/pulp.log

Actual results:
notifications: Successfully published content view 'forge_test4' from definition 'forge_test4'. 

pulp.log: 2013-10-21 11:21:50,192 pulp.server.managers.repo.publish:INFO: publish failed for repo [Katello_Infrastructure-dev-forge_test4-forge-forge] with distributor ID [Katello_Infrastructure-dev-forge_test4-forge-forge]

Expected results:
notifications: some error or failure.

pulp.log: same error

Comment 2 David Davis 2013-10-23 15:38:16 UTC
Here's the tasks we're getting back from the API after the publish:

{"task_group_id"=>nil,
 "call_request_id"=>"b885e309-a743-4acd-9b24-d1d09f315e04",
 "exception"=>nil,
 "_href"=>"/pulp/api/v2/tasks/b885e309-a743-4acd-9b24-d1d09f315e04/",
 "task_id"=>"b885e309-a743-4acd-9b24-d1d09f315e04",
 "call_request_tags"=>
  ["pulp:repository:ACME_Corporation-Library-PF30982-PForge-pforge",
   "pulp:action:publish"],
 "reasons"=>[],
 "start_time"=>"2013-10-23T13:45:22Z",
 "traceback"=>nil,
 "schedule_id"=>nil,
 "finish_time"=>"2013-10-23T13:45:23Z",
 "state"=>"finished",
 "result"=>nil,
 "dependency_failures"=>{},
 "call_request_group_id"=>nil,
 "progress"=>{},
 "principal_login"=>"admin",
 "response"=>"accepted",
 "tags"=>
  ["pulp:repository:ACME_Corporation-Library-PF30982-PForge-pforge",
   "pulp:action:publish"]}
 
 
{"task_group_id"=>nil,
 "exception"=>nil,
 "traceback"=>nil,
 "_href"=>"/pulp/api/v2/tasks/e324b98c-dce0-46fb-922d-6e43afe337b9/",
 "task_id"=>"e324b98c-dce0-46fb-922d-6e43afe337b9",
 "call_request_tags"=>
  ["pulp:repository:ACME_Corporation-Library-PF30982-PForge-pforge",
   "pulp:action:publish"],
 "reasons"=>
  [{"operation"=>"update",
    "resource_type"=>"repository",
    "resource_id"=>"ACME_Corporation-Library-PF30982-PForge-pforge"}],
 "start_time"=>"2013-10-23T13:45:23Z",
 "tags"=>
  ["pulp:repository:ACME_Corporation-Library-PF30982-PForge-pforge",
   "pulp:action:publish"],
 "state"=>"finished",
 "finish_time"=>"2013-10-23T13:45:27Z",
 "dependency_failures"=>{},
 "schedule_id"=>nil,
 "progress"=>{},
 "call_request_group_id"=>nil,
 "call_request_id"=>"e324b98c-dce0-46fb-922d-6e43afe337b9",
 "principal_login"=>"admin",
 "response"=>"postponed",
 "result"=>nil}

Comment 3 David Davis 2013-11-05 16:04:04 UTC
https://github.com/Katello/katello/pull/3308

Comment 4 David Davis 2013-11-05 16:06:22 UTC
katello SHA aa40fa41e2951a011f66150da09841e96281c7ee

1021612: Checking for name conflicts before publish/refresh

Comment 7 Corey Welton 2013-11-07 17:09:21 UTC
QA Verified, we now get the following message rather than a blind "pass"

Failed to publish content view 'fullforge_cvd_published' from definition 'fullforge_cvd'. Selected puppet repository has 243 name conflict(s) and cannot be published.
Click here for more details.

Satellite-6.0.2-RHEL-6-20131106.0

Comment 8 Bryan Kearney 2014-04-24 17:11:32 UTC
This was verified and delivered with MDP2. Closing it out.

Comment 9 Bryan Kearney 2014-04-24 17:12:22 UTC
This was delivered and verified with MDP2. Closing the bug.