Bug 1021686
| Summary: | refactor AFR module | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Anand Avati <aavati> |
| Component: | replicate | Assignee: | Anand Avati <aavati> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | bugs, chrisw, gluster-bugs, nullpai, pkarampu |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.6.0beta1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-11 08:24:16 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Anand Avati
2013-10-21 19:27:37 UTC
REVIEW: http://review.gluster.org/6112 (syncops: expose @flags in syncop_rmdir()) posted (#3) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#5) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6031 (replace-brick: remove code from cli and glusterd) posted (#5) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6112 (syncops: expose @flags in syncop_rmdir()) posted (#4) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#6) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6031 (replace-brick: remove code from cli and glusterd) posted (#6) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#7) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#8) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#9) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#10) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#11) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#12) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#13) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#1) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#14) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#2) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#15) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#3) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#16) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#4) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#1) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#17) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#2) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#5) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#1) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#18) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#3) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#6) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#2) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#19) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#7) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#4) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#3) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#20) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#5) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#8) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#4) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#21) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#6) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#9) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#5) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#22) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#10) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#7) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#6) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#23) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#8) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#11) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#7) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#24) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#12) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#9) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#8) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#25) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#13) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#10) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#9) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#26) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#14) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#11) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#10) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#27) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#15) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#12) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#11) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#28) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#16) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#13) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#12) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#29) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6888 (syncops: add support for custom PID) posted (#17) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6932 (storage/posix: calculate checksum only over read data) posted (#14) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6941 (core: add @xdata parameter to syncop_[f]removexattr()) posted (#13) for review on master by Anand Avati (avati) COMMIT: http://review.gluster.org/6941 committed in master by Anand Avati (avati) ------ commit 0cab34b3a5e94267bf6b39669b6e85af1fab8f3d Author: Anand Avati <avati> Date: Fri Feb 7 14:29:34 2014 -0800 core: add @xdata parameter to syncop_[f]removexattr() To be used in afr metadata self-heal Change-Id: I8dac4b19d61e331702427eeb5b606aab3d20b328 BUG: 1021686 Signed-off-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/6941 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra Bhat <raghavendra> COMMIT: http://review.gluster.org/6932 committed in master by Anand Avati (avati) ------ commit 7b4d6e3ec61e9cb0b9d0ffa0aef2117b96e63f65 Author: Anand Avati <avati> Date: Thu Feb 6 12:32:01 2014 -0800 storage/posix: calculate checksum only over read data If the last block of a file is not aligned to the requested size, checksum is calculated over junk data in the iobuf. Or it could be zeroes, resulting in a spurious checksum match in self-heal. Change-Id: I41422e08de90013dabfc348ec6fbb8ecdd4f8fb8 BUG: 1021686 Signed-off-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/6932 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra Bhat <raghavendra> COMMIT: http://review.gluster.org/6888 committed in master by Anand Avati (avati) ------ commit 3571066deedfe858ef37f09d6ad2160e5dd7b803 Author: Anand Avati <avati> Date: Mon Jan 27 00:58:45 2014 -0800 syncops: add support for custom PID AFR self-heal needs to issue syncops with special PID. Extend the custom UID/GID support to include custom PIDs Change-Id: I736c0e177f862b029f203acc87f9eb46c8cb839b BUG: 1021686 Signed-off-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/6888 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra Bhat <raghavendra> REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#30) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#31) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#32) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#33) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#34) for review on master by Anand Avati (avati) REVIEW: http://review.gluster.org/6010 (cluster/afr: refactor) posted (#35) for review on master by Anand Avati (avati) COMMIT: http://review.gluster.org/6010 committed in master by Vijay Bellur (vbellur) ------ commit 6d3739292b7b51d2ddbab75b5f884fb38925b943 Author: Anand Avati <avati> Date: Thu Jan 16 16:14:36 2014 -0800 cluster/afr: refactor - Remove client side self-healing completely (opendir, openfd, lookup) - Re-work readdir-failover to work reliably in case of NFS - Remove unused/dead lock recovery code - Consistently use xdata in both calls and callbacks in all FOPs - Per-inode event generation, used to force inode ctx refresh - Implement dirty flag support (in place of pending counts) - Eliminate inode ctx structure, use read subvol bits + event_generation - Implement inode ctx refreshing based on event generation - Provide backward compatibility in transactions - remove unused variables and functions - make code more consistent in style and pattern - regularize and clean up inode-write transaction code - regularize and clean up dir-write transaction code - regularize and clean up common FOPs - reorganize transaction framework code - skip setting xattrs in pending dict if nothing is pending - re-write self-healing code using syncops - re-write simpler self-heal-daemon Change-Id: I1e4080c9796c8a2815c2dab4be3073f389d614a8 BUG: 1021686 Signed-off-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/6010 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> *** Bug 951800 has been marked as a duplicate of this bug. *** A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html [2] http://supercolony.gluster.org/pipermail/gluster-users/ This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report. glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html [2] http://supercolony.gluster.org/mailman/listinfo/gluster-users |