Bug 1021902

Summary:	hosted-engine --add-console-password should have interactive option
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	movciari
Component:	ovirt-hosted-engine-setup	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED ERRATA	QA Contact:	Leonid Natapov <lnatapov>
Severity:	high	Docs Contact:
Priority:	high
Version:	3.3.0	CC:	danken, didi, iheim, oschreib, pstehlik, sbonazzo, scohen
Target Milestone:	---	Keywords:	Triaged
Target Release:	3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	integration
Fixed In Version:	ovirt-hosted-engine-setup-1.0.0-0.10.1.rc.el6ev	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-21 16:54:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description movciari 2013-10-22 10:05:23 UTC

Description of problem:
when you want to set console password, you have to write it in commandline option, like "hosted-engine --add-console-password=badpassword"

there should be an option to input password interactively, so it doesn't stay in bash history, scrollback buffer of screen or anywhere else, for example "hosted-engine --add-console-password --interactive"

Version-Release number of selected component (if applicable):
is19

How reproducible:
always

Steps to Reproduce:
1. hosted-engine --help
2. use --add-console-password as you see it in help

Actual results:


Expected results:


Additional info:

Comment 1 Itamar Heim 2013-10-23 06:01:22 UTC

please use same logic as all other utilities for password handling

Comment 2 Sandro Bonazzola 2013-10-23 06:50:31 UTC

I think it should be only interactive, using an env var to allow you to automate process for testing if really needed.

Comment 3 Yedidyah Bar David 2013-11-20 10:33:12 UTC

vdsClient only accepts a password on the command line, so we'll pass it to it this way anyway and it will be seen with 'ps'. Do we want to also make vdsClient accept passwords using other means?

Comment 4 Sandro Bonazzola 2013-11-20 10:44:46 UTC

(In reply to Yedidyah Bar David from comment #3)
> vdsClient only accepts a password on the command line, so we'll pass it to
> it this way anyway and it will be seen with 'ps'. Do we want to also make
> vdsClient accept passwords using other means?

I think it should. Please open a BZ about it on vdsm, we'll update hosted-engine code when they'll fix it. 

For now, let's fix this on our command line.

Comment 5 Dan Kenigsberg 2013-11-20 11:45:56 UTC

Please avoid using the vdsClient command line. It's broken in so many forms. Since hosted-engine is a python app, importing vdsm.vdscli and using it to contact the running vdsm process is much more robust.

Comment 6 Yedidyah Bar David 2013-11-20 12:00:24 UTC

(In reply to Dan Kenigsberg from comment #5)
> Please avoid using the vdsClient command line. It's broken in so many forms.
> Since hosted-engine is a python app, importing vdsm.vdscli and using it to
> contact the running vdsm process is much more robust.

Actually hosted-engine is a shell script. Only ovirt-hosted-engine-setup, which is called by '--deploy', is a python app.

Comment 7 Sandro Bonazzola 2013-11-21 13:45:05 UTC

Patches merged on upstream master and 1.0 branches.

Comment 9 Leonid Natapov 2013-12-09 15:43:09 UTC

is26. fixed.

Comment 10 errata-xmlrpc 2014-01-21 16:54:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0083.html