Bug 1021907
| Summary: | simplify keyboard layout display: "English (English (US))" -> "English (US)" etc | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> | ||||
| Component: | anaconda | Assignee: | Vratislav Podzimek <vpodzime> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 20 | CC: | anaconda-maint-list, awilliam, g.kaviyarasu, i18n-bugs, jonathan, mfabian, vanmeeuwen+fedora | ||||
| Target Milestone: | --- | Keywords: | i18n, Patch, Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | RejectedFreezeException | ||||||
| Fixed In Version: | pykickstart-1.99.46-1.fc20 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-11-24 04:00:18 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Good idea! I'll send this patch to anaconda-patches for a review. Discussed at 2013-10-23 freeze exception review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2013-10-23/f20-blocker-review.2013-10-23-16.00.log.txt . Rejected as a freeze exception issue: this is an entirely cosmetic and fairly trivial change to a vital and very fragile element of the installer, and that's a bad thing to take during a freeze period. This does not mean the change can't go into F20, but we'd prefer it be landed post-Beta, so we can catch any breakage early in Final testing without destabilizing Beta. (In reply to Adam Williamson from comment #2) > Discussed at 2013-10-23 freeze exception review meeting: > http://meetbot.fedoraproject.org/fedora-blocker-review/2013-10-23/f20- > blocker-review.2013-10-23-16.00.log.txt . Rejected as a freeze exception > issue: this is an entirely cosmetic and fairly trivial change to a vital and > very fragile element of the installer, and that's a bad thing to take during > a freeze period. This does not mean the change can't go into F20, but we'd > prefer it be landed post-Beta, so we can catch any breakage early in Final > testing without destabilizing Beta. I'm sorry, but I've accidentally pushed the patch to the f20-branch as well as to the master branch. Shall I revert it or could we give it a try and revert it in case of some troubles? I've tested it and everything looks okay and working as expected. Sorry for complicating things. python-blivet-0.23.3-1.fc20, anaconda-20.25.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/anaconda-20.25.5-1.fc20,python-blivet-0.23.3-1.fc20 python-blivet-0.23.3-1.fc20, anaconda-20.25.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/anaconda-20.25.5-1.fc20,python-blivet-0.23.3-1.fc20 The change has been reverted, but the scripts grabbing list of bugs to put into an update didn't get that. Moving back to POST. Package python-blivet-0.23.3-1.fc20, anaconda-20.25.5-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-blivet-0.23.3-1.fc20 anaconda-20.25.5-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-20387/anaconda-20.25.5-1.fc20,python-blivet-0.23.3-1.fc20 then log in and leave karma (feedback). Still reverted Package python-blivet-0.23.3-1.fc20, anaconda-20.25.6-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-blivet-0.23.3-1.fc20 anaconda-20.25.6-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-20387/anaconda-20.25.6-1.fc20,python-blivet-0.23.3-1.fc20 then log in and leave karma (feedback). python-blivet-0.23.3-1.fc20, anaconda-20.25.6-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. Still reverted. anaconda-20.25.8-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/anaconda-20.25.8-1.fc20 Package anaconda-20.25.8-1.fc20, pykickstart-1.99.46-1.fc20, python-blivet-0.23.5-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing anaconda-20.25.8-1.fc20 pykickstart-1.99.46-1.fc20 python-blivet-0.23.5-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-21553/pykickstart-1.99.46-1.fc20,python-blivet-0.23.5-1.fc20,anaconda-20.25.8-1.fc20 then log in and leave karma (feedback). pykickstart-1.99.46-1.fc20, python-blivet-0.23.5-1.fc20, anaconda-20.25.9-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 814924 [details] anaconda-20.25.1-keyboard-layout-naming-6.patch Description of problem: The the new anaconda UI I really wanted to have this patch. Currently this is a lot of repetition in the way anaconda displays keyboard layout names in its UI, since it uses roughly _ iso_lang.name (_ xkb.description) and often xkb.description starts with langname resulting in: eg: - English (English (US)) - Japanese (Japanese) - Arabic (Arabic) - German (German (Austria)) - <Language> (<Language> (<variant>)) - etc The attached patch which I have tested carefully for various major languages improves this so that instead it display just: - English (US) - Japanese - Arabic - German (Austria) - <Language> (<variant>) - etc For layouts where description does not start with lang the output remains same are currently. Version-Release number of selected component (if applicable): anaconda-20 How reproducible: 100% Steps to Reproduce: 1. Install fedora with anaconda Actual results: 1. Installer shows US layout as "English (English (US))" Expected results: 2. Installer should show US layout as "English (US)" Additional info: I feel the current output is confusing and suboptimal so I hope this patch can be used in Fedora 20.