Bug 1021930
Summary: | From webUI, Config file compare doesn't check for user, group and permissions. | ||||||
---|---|---|---|---|---|---|---|
Product: | [Community] Spacewalk | Reporter: | Neha <nerawat> | ||||
Component: | Clients | Assignee: | Stephen Herr <sherr> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Red Hat Satellite QA List <satqe-list> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 2.2 | CC: | sashinde | ||||
Target Milestone: | --- | Keywords: | Reopened | ||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | rhncfg-5.10.73-1 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2014-07-18 15:08:47 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1207293 | ||||||
Attachments: |
|
Description
Neha
2013-10-22 10:59:40 UTC
Current code for diff functionality else: result = ''.join(diff(temp_file, path)) os.unlink(temp_file) return sectx_result + result It displays results -> content diff + selinux diff And from cmd line: rhncfg-client verify /root/nerawat/nerawat2/test1 /root/nerawat/nerawat2/test2 mode,modified /root/nerawat/test1 user,group,mode,selinux,modified /root/nerawat/test2 /root/nerawat/test3 selinux /root/nerawat/test4 /root/test Created attachment 814936 [details]
proposed patch
According to current functionality only selinux check and check for links SELinux contexts differ: actual: [root:object_r:user_home_dir_t], expected: [user_u:role_r] Added for group, user and mod: User name differ: actual: [nerawat], expected: [root] Group name differ: actual: [nerawat], expected: [root] File mode differ: actual: [777], expected: [775] ~ Neha *** This bug has been marked as a duplicate of bug 1120802 *** I'm going to use this bug as the tracker for releaseing the changes that are in bug 1120802 and bug 1113848 to Spacewalk 2.2. These packages should fix: 1) always showing "differences exist" in the webui even though the diff is blank 2) improper diffing of selinux contexts 3) improper diffing of ownership / permissions Cherry-picking to Spacewalk 2.2: da0ac46b711066930eee7c9c2231d3743a635b70 a14909cc92c49b635270fd008991076021c9d614 13f60e4746d717c808545daa030d0be5b2ac976d 954540fae59babd51afe19c98fc31d4a5695963d |