Bug 1021977

Summary: FTBFS: error: 'OpenImageIO::v1_2::spin_mutex' has no member named 'try_lock'
Product: [Fedora] Fedora Reporter: Karsten Hopp <karsten>
Component: OpenImageIOAssignee: Richard Shaw <hobbes1069>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: medium    
Version: 20CC: hobbes1069
Target Milestone: ---   
Target Release: ---   
Hardware: powerpc   
OS: Linux   
Whiteboard:
Fixed In Version: OpenImageIO-1.2.3-3.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-21 02:15:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Karsten Hopp 2013-10-22 12:37:54 UTC
Description of problem:
OpenImageIO-1.2.1 fails to build on PPC in F20 and Rawhide:
/builddir/build/BUILD/oiio-Release-1.2.1/src/libtexture/imagecache.cpp: In member function 'void OpenImageIO::v1_2::pvt::ImageCacheImpl::check_max_files(OpenImageIO::v1_2::pvt::ImageCachePerThreadInfo*)':
/builddir/build/BUILD/oiio-Release-1.2.1/src/libtexture/imagecache.cpp:1056:30: error: 'OpenImageIO::v1_2::spin_mutex' has no member named 'try_lock'
     if (! m_file_sweep_mutex.try_lock())
                              ^
[ 24%] Building CXX object libOpenImageIO/CMakeFiles/OpenImageIO.dir/__/cineon.imageio/libcineon/Codec.cpp.o

Version-Release number of selected component (if applicable):
OpenImageIO-1.2.1-2

How reproducible:
always

Steps to Reproduce:
1. ppc-koji build --scratch f20 OpenImageIO-1.2.1-1.fc20.src.rpm
2.
3.

Actual results:
F20: http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1464201
F21: http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1469205

Comment 1 Richard Shaw 2013-10-22 14:56:53 UTC
Ran into this for the EPEL 6 build as well but I don't know enough about PPC to fix it.

Comment 2 Richard Shaw 2013-11-06 13:44:34 UTC
Someone else ran into this problem on a older X86 arch and this is the proposed (but yet untested) fix:
https://github.com/OpenImageIO/oiio/pull/738.patch

I'll try a ppc build if I have access, never done it before.

Comment 3 Richard Shaw 2013-11-06 14:06:57 UTC
Success!

http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=1512450

The s390 patch still needs to be fixed but that's a separate problem from this.

I'll work on committing the update sometime today.

Comment 4 Richard Shaw 2013-11-06 17:26:09 UTC
I have completed a new build with the new patch in place for the primary arches:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6145034

Please verify you can complete official builds for ppc and close the bug if you're successful.

Comment 5 Karsten Hopp 2013-12-10 10:14:09 UTC
Thanks, OpenImageIO-1.2.3-1.fc21 built fine on PPC. 
Would you mind doing an update on F20, too ? Or is 1.2.3 incompatible to 1.2.1 ?

Comment 6 Richard Shaw 2013-12-10 13:52:58 UTC
No, should be ABI compatible update. On a side note, the 1.3.X series is now releaed. I'll do a ppc scratch build after I've done some testing on x86.

Comment 7 Richard Shaw 2013-12-10 19:17:52 UTC
Primary arch builds are complete for F20. I'm assuming you will do the PPC builds,  correct?

Comment 8 Karsten Hopp 2013-12-11 15:29:39 UTC
Yes, our scripts will pick up any builds done on the primary archs.
OpenImageIO-1.2.3-3.fc20 got already build on PPC and we now just need the bodhi update so that we can pull it into F20 or F20-updates

Thanks for the fixed package !

Comment 9 Fedora Update System 2013-12-11 16:06:53 UTC
OpenImageIO-1.2.3-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/OpenImageIO-1.2.3-3.fc20

Comment 10 Fedora Update System 2013-12-12 16:32:27 UTC
Package OpenImageIO-1.2.3-3.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing OpenImageIO-1.2.3-3.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-23259/OpenImageIO-1.2.3-3.fc20
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2013-12-21 02:15:17 UTC
OpenImageIO-1.2.3-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.