Bug 1022028
| Summary: | package count doesn't match with actual packages in repodata | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Daniel Mach <dmach> | ||||
| Component: | createrepo | Assignee: | Valentina Mukhamedzhanova <vmukhame> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Karel Srot <ksrot> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 7.0 | CC: | dapospis, dmach, james.antill, jzeleny, ksrot, lmacken, packaging-team-maint, vmukhame | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | createrepo-0.9.9-23.el7 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | 1022001 | ||||||
| : | 1596211 (view as bug list) | Environment: | |||||
| Last Closed: | 2014-06-13 09:40:56 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1022001 | ||||||
| Bug Blocks: | 578256 | ||||||
| Attachments: |
|
||||||
|
Description
Daniel Mach
2013-10-22 14:07:40 UTC
We'd like to create XML files in one pass, and since the package count is saved first, updating it when some of the RPM files could not be processed is not trivial. I see three possible solutions: a) add an extra stat() pass in "createrepo -i" case, and remove non-existing files from the list. Then we'll use the correct package count. However, this won't work 100% .. eg zero-sized *.rpm files fail too late. b) re-compress all three *.xml files when some RPMs could not be processed, updating the "packages" attribute. It involves some re-parsing of the XML data, and is pretty ugly. However, (when it works) it covers all failure modes. c) do some sanity checking on the file list first, then run as usual. When some files could not be processed, don't try to fix up the package count. exit with an error instead. IMO viable solution is implementing either b or a+c. If all you want to handle is "file not found", then a+c is probably better (although I've implemented b already). What about following: * scan for all files (no stat) from package list (verify they're on disk) * set packages=<package count> * if a package fails to read * report error * don't write new repodata * exit with non-0 exit code Created attachment 815304 [details]
Make sure the "packages" attribute is always correct.
The patch above checks all local files specified with -i option to be readable first. When some rpms fail after the "packages" count has been already written, it's a fatal error ($? == 1). We can merge the upstream patch.
commit 84a237f6a2e661879147e1ee5f9a2be984267991
Author: Zdenek Pavlas <zpavlas>
Date: Wed Oct 23 11:42:02 2013 +0200
Make sure the "packages" attribute is always correct. BZ 1022001
We create XML files in one pass and the package count is stored
first. We need the count to be correct, so when a package is
being skipped, it must be a fatal error.
This request was resolved in Red Hat Enterprise Linux 7.0. Contact your manager or support representative in case you have further questions about the request. |